[PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Paul Gortmaker]

In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
Move protocol helpers out of the MFD driver") there was a select
added on CHROME_PLATFORMS, which leads to the following for ppc/mips:

warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
direct dependencies (X86 || ARM)

Presumably the above means MFD_CROS_EC is only currently useful
on x86 and ARM, so lets limit it to there.

Cc: Lee Jones <lee.jones@linaro.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Olof Johansson <olof@lixom.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 653815950aa2..d3235e6f1953 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -94,6 +94,7 @@ config MFD_AXP20X
 
 config MFD_CROS_EC
 	tristate "ChromeOS Embedded Controller"
+	depends on X86 || ARM
 	select MFD_CORE
 	select CHROME_PLATFORMS
 	select CROS_EC_PROTO
-- 
2.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Javier Martinez Canillas]

Hello Paul,

On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> Move protocol helpers out of the MFD driver") there was a select
> added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> 
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> direct dependencies (X86 || ARM)
>

Right, sorry for missing that and thank a lot for taking care of it.
 
> Presumably the above means MFD_CROS_EC is only currently useful
> on x86 and ARM, so lets limit it to there.
>

That is correct, although I wonder if CHROME_PLATFORMS should not
also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
have at least build coverage on other architectures.

I can't think for a reason to not be buildable on other archs...

> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..d3235e6f1953 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,6 +94,7 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> +	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO
> 

...but that is orthogonal to this patch so:

Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Lee Jones]

On Sun, 21 Jun 2015, Javier Martinez Canillas wrote:

> Hello Paul,
> 
> On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> > Move protocol helpers out of the MFD driver") there was a select
> > added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> > 
> > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> > direct dependencies (X86 || ARM)
> >
> 
> Right, sorry for missing that and thank a lot for taking care of it.
>  
> > Presumably the above means MFD_CROS_EC is only currently useful
> > on x86 and ARM, so lets limit it to there.
> >
> 
> That is correct, although I wonder if CHROME_PLATFORMS should not
> also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
> have at least build coverage on other architectures.
> 
> I can't think for a reason to not be buildable on other archs...

Right.  Will you fix that Javier?

> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: Olof Johansson <olof@lixom.net>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> >  drivers/mfd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 653815950aa2..d3235e6f1953 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -94,6 +94,7 @@ config MFD_AXP20X
> >  
> >  config MFD_CROS_EC
> >  	tristate "ChromeOS Embedded Controller"
> > +	depends on X86 || ARM
> >  	select MFD_CORE
> >  	select CHROME_PLATFORMS
> >  	select CROS_EC_PROTO
> > 
> 
> ...but that is orthogonal to this patch so:
> 
> Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Best regards,
> Javier

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Heiko Stübner]

Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones:
> On Sun, 21 Jun 2015, Javier Martinez Canillas wrote:
> > Hello Paul,
> > 
> > On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> > > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> > > Move protocol helpers out of the MFD driver") there was a select
> > > added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> > > 
> > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> > > direct dependencies (X86 || ARM)
> > 
> > Right, sorry for missing that and thank a lot for taking care of it.
> > 
> > > Presumably the above means MFD_CROS_EC is only currently useful
> > > on x86 and ARM, so lets limit it to there.
> > 
> > That is correct, although I wonder if CHROME_PLATFORMS should not
> > also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
> > have at least build coverage on other architectures.
> > 
> > I can't think for a reason to not be buildable on other archs...
> 
> Right.  Will you fix that Javier?

looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might 
also be a nice addition to this list, but I'm not sure if there are more ec 
changes involved.

Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Javier Martinez Canillas]

On 06/24/2015 04:21 PM, Heiko Stübner wrote:
> Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones:
>> On Sun, 21 Jun 2015, Javier Martinez Canillas wrote:
>> > Hello Paul,
>> > 
>> > On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
>> > > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
>> > > Move protocol helpers out of the MFD driver") there was a select
>> > > added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
>> > > 
>> > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
>> > > direct dependencies (X86 || ARM)
>> > 
>> > Right, sorry for missing that and thank a lot for taking care of it.
>> > 
>> > > Presumably the above means MFD_CROS_EC is only currently useful
>> > > on x86 and ARM, so lets limit it to there.
>> > 
>> > That is correct, although I wonder if CHROME_PLATFORMS should not
>> > also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
>> > have at least build coverage on other architectures.
>> > 
>> > I can't think for a reason to not be buildable on other archs...
>> 
>> Right.  Will you fix that Javier?
>

Yes, I was waiting to see if Paul agreed and wanted to re-spin his patches
or if anyone else had other opinions.
 
> looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might 
> also be a nice addition to this list, but I'm not sure if there are more ec 
> changes involved.
> 

Right, on a second thought I wonder if having CHROME_PLATFORMS depends on
depends on X86 || ARM even makes sense. I see that the individual drivers
already depend on a certain architecture. i.e: CROS_EC_LPC on x86 because
LPC is only found on x86, etc.

So maybe we can just remove the constrain from CHROME_PLATFORMS and let
it be selected on all architectures if someone choose to.

I'll double check and post a patch on top of Paul's tomorrow.

Best regards,
Javier

Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM

[Lee Jones]

On Sat, 20 Jun 2015, Paul Gortmaker wrote:

> In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> Move protocol helpers out of the MFD driver") there was a select
> added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> 
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> direct dependencies (X86 || ARM)
> 
> Presumably the above means MFD_CROS_EC is only currently useful
> on x86 and ARM, so lets limit it to there.
> 
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..d3235e6f1953 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,6 +94,7 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> +	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog