* [PATCH] drivers/memstick/host/tifm_ms.c breakage
@ 2008-02-13 3:56 Al Viro
2008-02-13 4:11 ` Al Viro
2008-02-13 5:12 ` Alex Dubov
0 siblings, 2 replies; 3+ messages in thread
From: Al Viro @ 2008-02-13 3:56 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, Alex Dubov
readl(sock + ...) that should've been readl(sock->addr + ...)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
index f55b71a..4fb2421 100644
--- a/drivers/memstick/host/tifm_ms.c
+++ b/drivers/memstick/host/tifm_ms.c
@@ -282,7 +282,7 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host)
writel(TIFM_MS_SYS_LATCH
| readl(sock->addr + SOCK_MS_SYSTEM),
- sock + SOCK_MS_SYSTEM);
+ sock->addr + SOCK_MS_SYSTEM);
writel(0, sock->addr + SOCK_MS_DATA);
dev_dbg(&sock->dev, "writing %x\n", 0);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
2008-02-13 3:56 [PATCH] drivers/memstick/host/tifm_ms.c breakage Al Viro
@ 2008-02-13 4:11 ` Al Viro
2008-02-13 5:12 ` Alex Dubov
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2008-02-13 4:11 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, Alex Dubov
On Wed, Feb 13, 2008 at 03:56:59AM +0000, Al Viro wrote:
> readl(sock + ...) that should've been readl(sock->addr + ...)
s/readl(/writel(..., / in the changelog message...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
2008-02-13 3:56 [PATCH] drivers/memstick/host/tifm_ms.c breakage Al Viro
2008-02-13 4:11 ` Al Viro
@ 2008-02-13 5:12 ` Alex Dubov
1 sibling, 0 replies; 3+ messages in thread
From: Alex Dubov @ 2008-02-13 5:12 UTC (permalink / raw)
To: Al Viro, Linus Torvalds; +Cc: linux-kernel
--- Al Viro <viro@ZenIV.linux.org.uk> wrote:
> readl(sock + ...) that should've been readl(sock->addr + ...)
>
Thanks. It's a first member in struct, so the problem was just sitting there unnoticed.
____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-13 5:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 3:56 [PATCH] drivers/memstick/host/tifm_ms.c breakage Al Viro
2008-02-13 4:11 ` Al Viro
2008-02-13 5:12 ` Alex Dubov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox