public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Daniel Baluta <daniel.baluta@intel.com>,
	Jonathan Cameron <jic23@kernel.org>
Cc: Cristina Opriceana <cristina.opriceana@gmail.com>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"octavian.purdila@intel.com" <octavian.purdila@intel.com>
Subject: Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup
Date: Mon, 22 Jun 2015 10:26:19 +0200	[thread overview]
Message-ID: <5587C6AB.8070903@metafoo.de> (raw)
In-Reply-To: <CAEnQRZCHxqkLO5ox2em7guJdp3x-wyP9CZRC656HcZPcptNLCg@mail.gmail.com>

On 06/21/2015 03:57 PM, Daniel Baluta wrote:
> On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 11/06/15 13:06, Cristina Opriceana wrote:
>>> This patch renames the top half handler and the bottom half handler
>>> of iio_triggered_buffer_setup() in accordance with their usage.
>>> The names of the parameters were swapped, thus creating confusion.
>>>
>>> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
>> Good point.  This is definitely misleading.  I wonder if the _th naming
>> is a good idea anymore though given that the bottom half (in the traditional
>> sense) is now a thread based call and hence the th might be confusing?
>> Perhaps the h and thread naming used in the pollfunc code would be clearer?
>>
>
> Sounds like a good idea. Cristina can prepare a patch for this.
>
>> Lars, this bit was yours originally.  Any thoughts?

Jonathan, that's your naming convention I merely added the wrapper function.

I'm OK with changing the naming.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2015-06-22  8:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 12:06 [PATCH] iio: Fix parameters in iio_triggered_buffer_setup Cristina Opriceana
2015-06-11 12:53 ` Daniel Baluta
2015-06-14 10:20 ` Jonathan Cameron
2015-06-21 13:57   ` Daniel Baluta
2015-06-22  8:26     ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5587C6AB.8070903@metafoo.de \
    --to=lars@metafoo.de \
    --cc=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox