From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933671AbbFVMn0 (ORCPT ); Mon, 22 Jun 2015 08:43:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:23655 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933559AbbFVMnT (ORCPT ); Mon, 22 Jun 2015 08:43:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,659,1427785200"; d="scan'208";a="748134700" Message-ID: <55880254.5070604@intel.com> Date: Mon, 22 Jun 2015 15:40:52 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa Subject: Re: [PATCH V6 05/17] perf tools: Add Intel PT instruction decoder References: <1432906425-9911-1-git-send-email-adrian.hunter@intel.com> <1432906425-9911-6-git-send-email-adrian.hunter@intel.com> <20150618222941.GJ3079@kernel.org> <20150619154415.GL3079@kernel.org> In-Reply-To: <20150619154415.GL3079@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/15 18:44, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 18, 2015 at 07:29:41PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, May 29, 2015 at 04:33:33PM +0300, Adrian Hunter escreveu: >>> Add support for decoding instructions for Intel Processor Trace. The >>> kernel x86 instruction decoder is used for this. >> >> Ok, but we don't access kernel header files directly, and: >> >> [acme@zoo linux]$ find . -name "insn.h" >> ./arch/x86/include/asm/insn.h >> ./arch/arm64/include/asm/insn.h >> ./arch/arm/include/asm/insn.h >> [acme@zoo linux]$ find /usr/include -name "insn.h" >> [acme@zoo linux]$ >> >> But I need to look more into this patch to figure out if this is >> something generated at build time, etc, but before that I found a >> problem: >> >> So: >> >>> +inat_tables_script = ../../arch/x86/tools/gen-insn-attr-x86.awk >>> +inat_tables_maps = ../../arch/x86/lib/x86-opcode-map.txt >> >> These need to go into tools/perf/MANIFEST, so that: > > So, after adding: > > diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST > index fe50a1b34aa0..4e5662d8c274 100644 > --- a/tools/perf/MANIFEST > +++ b/tools/perf/MANIFEST > @@ -58,6 +58,13 @@ include/linux/stringify.h > lib/hweight.c > lib/rbtree.c > include/linux/swab.h > +arch/x86/lib/insn.c > +arch/x86/lib/inat.c > +arch/x86/include/asm/insn.h > +arch/x86/include/asm/inat.h > +arch/x86/include/asm/inat_types.h > +arch/x86/tools/gen-insn-attr-x86.awk > +arch/x86/lib/x86-opcode-map.txt > arch/*/include/asm/unistd*.h > arch/*/include/uapi/asm/unistd*.h > arch/*/include/uapi/asm/perf_regs.h > > The test passes: > > [acme@zoo linux]$ make -C tools/perf -f tests/make tarpkg && echo Ok > make: Entering directory '/home/git/linux/tools/perf' > - tarpkg: ./tests/perf-targz-src-pkg . > make: Leaving directory '/home/git/linux/tools/perf' > Ok > [acme@zoo linux]$ > > Merging these changes with this changeset to continue testing... Thank you! :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/