From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbbFVUkc (ORCPT ); Mon, 22 Jun 2015 16:40:32 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:47488 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbbFVUkY (ORCPT ); Mon, 22 Jun 2015 16:40:24 -0400 Message-ID: <55887278.3010705@mailbox.org> Date: Mon, 22 Jun 2015 22:39:20 +0200 From: =?windows-1252?Q?Markus_B=F6hme?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Abdul, Hussain (H.)" , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "abbotti@mev.co.uk" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence References: <1434953361-23444-1-git-send-email-habdul@visteon.com> <1434953361-23444-3-git-send-email-habdul@visteon.com> In-Reply-To: <1434953361-23444-3-git-send-email-habdul@visteon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > --- a/drivers/staging/comedi/drivers/daqboard2000.c > +++ b/drivers/staging/comedi/drivers/daqboard2000.c > @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev, > return result; > > s = &dev->subdevices[2]; > - result = subdev_8255_init(dev, s, daqboard2000_8255_cb, > - dioP2ExpansionIO8Bit); > - if (result) > - return result; > - > - return 0; > + return subdev_8255_init(dev, s, daqboard2000_8255_cb, > + dioP2ExpansionIO8Bit); > } What do you think about horizontally aligning the parameters in the second line? They were previously. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/