* [PATCH v2 2/6] Staging: comedi: fl512: Simplify a trivial if-return sequence
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
@ 2015-06-22 6:10 ` Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 3/6] Staging: combine: daqboard2000: " Abdul, Hussain (H.)
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-22 6:10 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Abdul Hussain <habdul@visteon.com>
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
drivers/staging/comedi/drivers/fl512.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
index e1f4932..55cae61 100644
--- a/drivers/staging/comedi/drivers/fl512.c
+++ b/drivers/staging/comedi/drivers/fl512.c
@@ -136,11 +136,7 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &range_fl512;
s->insn_write = fl512_ao_insn_write;
- ret = comedi_alloc_subdev_readback(s);
- if (ret)
- return ret;
-
- return 0;
+ return comedi_alloc_subdev_readback(s);
}
static struct comedi_driver fl512_driver = {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-22 6:10 ` [PATCH v2 2/6] Staging: comedi: fl512: " Abdul, Hussain (H.)
@ 2015-06-22 6:11 ` Abdul, Hussain (H.)
2015-06-22 20:39 ` Markus Böhme
2015-06-22 6:11 ` [PATCH v2 4/6] Staging: comedi: dac02: " Abdul, Hussain (H.)
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-22 6:11 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Abdul Hussain <habdul@visteon.com>
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
drivers/staging/comedi/drivers/daqboard2000.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index 611b0a3..bb8a6b2 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
return result;
s = &dev->subdevices[2];
- result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
- dioP2ExpansionIO8Bit);
- if (result)
- return result;
-
- return 0;
+ return subdev_8255_init(dev, s, daqboard2000_8255_cb,
+ dioP2ExpansionIO8Bit);
}
static void daqboard2000_detach(struct comedi_device *dev)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence
2015-06-22 6:11 ` [PATCH v2 3/6] Staging: combine: daqboard2000: " Abdul, Hussain (H.)
@ 2015-06-22 20:39 ` Markus Böhme
0 siblings, 0 replies; 7+ messages in thread
From: Markus Böhme @ 2015-06-22 20:39 UTC (permalink / raw)
To: Abdul, Hussain (H.), gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
> return result;
>
> s = &dev->subdevices[2];
> - result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> - dioP2ExpansionIO8Bit);
> - if (result)
> - return result;
> -
> - return 0;
> + return subdev_8255_init(dev, s, daqboard2000_8255_cb,
> + dioP2ExpansionIO8Bit);
> }
What do you think about horizontally aligning the parameters in the second line?
They were previously.
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 4/6] Staging: comedi: dac02: Simplify a trivial if-return sequence
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-22 6:10 ` [PATCH v2 2/6] Staging: comedi: fl512: " Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 3/6] Staging: combine: daqboard2000: " Abdul, Hussain (H.)
@ 2015-06-22 6:11 ` Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 5/6] Staging: comedi: ni_daq_dio24: " Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 6/6] Staging: comedi: s626: " Abdul, Hussain (H.)
4 siblings, 0 replies; 7+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-22 6:11 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Abdul Hussain <habdul@visteon.com>
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
drivers/staging/comedi/drivers/dac02.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c
index a6798ad..a562df4 100644
--- a/drivers/staging/comedi/drivers/dac02.c
+++ b/drivers/staging/comedi/drivers/dac02.c
@@ -130,11 +130,7 @@ static int dac02_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &das02_ao_ranges;
s->insn_write = dac02_ao_insn_write;
- ret = comedi_alloc_subdev_readback(s);
- if (ret)
- return ret;
-
- return 0;
+ return comedi_alloc_subdev_readback(s);
}
static struct comedi_driver dac02_driver = {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 5/6] Staging: comedi: ni_daq_dio24: Simplify a trivial if-return sequence
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
` (2 preceding siblings ...)
2015-06-22 6:11 ` [PATCH v2 4/6] Staging: comedi: dac02: " Abdul, Hussain (H.)
@ 2015-06-22 6:11 ` Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 6/6] Staging: comedi: s626: " Abdul, Hussain (H.)
4 siblings, 0 replies; 7+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-22 6:11 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Abdul Hussain <habdul@visteon.com>
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index a208cb3..d9de83a 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -55,11 +55,7 @@ static int dio24_auto_attach(struct comedi_device *dev,
/* 8255 dio */
s = &dev->subdevices[0];
- ret = subdev_8255_init(dev, s, NULL, 0x00);
- if (ret)
- return ret;
-
- return 0;
+ return subdev_8255_init(dev, s, NULL, 0x00);
}
static struct comedi_driver driver_dio24 = {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 6/6] Staging: comedi: s626: Simplify a trivial if-return sequence
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
` (3 preceding siblings ...)
2015-06-22 6:11 ` [PATCH v2 5/6] Staging: comedi: ni_daq_dio24: " Abdul, Hussain (H.)
@ 2015-06-22 6:11 ` Abdul, Hussain (H.)
4 siblings, 0 replies; 7+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-22 6:11 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Abdul Hussain <habdul@visteon.com>
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
drivers/staging/comedi/drivers/s626.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 781918d..35f0f67 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2852,11 +2852,7 @@ static int s626_auto_attach(struct comedi_device *dev,
s->insn_read = s626_enc_insn_read;
s->insn_write = s626_enc_insn_write;
- ret = s626_initialize(dev);
- if (ret)
- return ret;
-
- return 0;
+ return s626_initialize(dev);
}
static void s626_detach(struct comedi_device *dev)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 7+ messages in thread