From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754376AbbFVXxq (ORCPT ); Mon, 22 Jun 2015 19:53:46 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:52160 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbbFVXxJ (ORCPT ); Mon, 22 Jun 2015 19:53:09 -0400 X-AuditID: cbfec7f5-f794b6d000001495-aa-55889fe353c3 Message-id: <55889FE0.7080101@samsung.com> Date: Tue, 23 Jun 2015 08:53:04 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Dan Carpenter , Tomasz Figa Cc: Thomas Abraham , Linus Walleij , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch v2 2/2] pinctrl: samsung: remove "out of memory" messages References: <20150622151315.GB14156@mwanda> In-reply-to: <20150622151315.GB14156@mwanda> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xK7qP53eEGiz/Imjx+t90FovXLwwt tt6Stuh//JrZYsqf5UwWmx5fY7XYPP8Po8XlXXPYLGac38dkcWzGEkaLVbv+MDpwe+ycdZfd Y9OqTjaPO9f2sHlsXlLv8fHpLRaPvi2rGD0+b5ILYI/isklJzcksSy3St0vgythzbA97wWHz ip3XnjI3MM7V7mLk5JAQMJF4t7iNEcIWk7hwbz1bFyMXh5DAUkaJ7ubvUM5TRomdix4BVXFw 8ApoSfQcNAVpYBFQlVj+dzUriM0mYCyxefkSNhBbVCBC4u3lk0wgNq+AoMSPyfdYQGwRgWCJ /TO/g9UzCyxmkpjw3wDEFhbwlZhy5ggziC0koC3Rs2Qt2EGcAjoSZ3Z+YwVZyyygJ3H/ohZE q7zE5jVvmScwCsxCsmEWQtUsJFULGJlXMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoTExdcd jEuPWR1iFOBgVOLhLZjcESrEmlhWXJl7iFGCg1lJhHfqHKAQb0piZVVqUX58UWlOavEhRmkO FiVx3pm73ocICaQnlqRmp6YWpBbBZJk4OKUaGHOfrVq/ISvmh0WQc26BTviX8O69E+1Zo5WM zxc6q+yJPG1t4TEt6orUHZPp60TclO84nGNRWN8tv+wqM4PTP9b6KjuNBzuuzf6+a1mZ0DaF 7ftd7zSqmRzl72LZfS6rUefeRfGlDXm1b+8orHs8/Z9TznTlWzs3G+Rl36yJnvw+8Xy8qu/W i0osxRmJhlrMRcWJANBE9SKHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.06.2015 00:13, Dan Carpenter wrote: > Checkpatch.pl complains about these: > > WARNING: Possible unnecessary 'out of memory' message > > The messages use a little extra RAM and they add a few extra lines of > code. We're probably never going to hit these out of memory situations > but if we did then kmalloc() has pretty good error messages built-in. > > Signed-off-by: Dan Carpenter Looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos5440.c b/drivers/pinctrl/samsung/pinctrl-exynos5440.c > index fa84db6..5574b8a 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos5440.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos5440.c > @@ -203,10 +203,8 @@ static int exynos5440_dt_node_to_map(struct pinctrl_dev *pctldev, > > /* Allocate memory for pin-map entries */ > map = kzalloc(sizeof(*map) * map_cnt, GFP_KERNEL); > - if (!map) { > - dev_err(dev, "could not alloc memory for pin-maps\n"); > + if (!map) > return -ENOMEM; > - } > *nmaps = 0; > > /* > @@ -214,10 +212,8 @@ static int exynos5440_dt_node_to_map(struct pinctrl_dev *pctldev, > * from the node name from which these map entries are be created. > */ > gname = kasprintf(GFP_KERNEL, "%s%s", np->name, GROUP_SUFFIX); > - if (!gname) { > - dev_err(dev, "failed to alloc memory for group name\n"); > + if (!gname) > goto free_map; > - } > > /* > * don't have config options? then skip over to creating function > @@ -228,10 +224,8 @@ static int exynos5440_dt_node_to_map(struct pinctrl_dev *pctldev, > > /* Allocate memory for config entries */ > cfg = kzalloc(sizeof(*cfg) * cfg_cnt, GFP_KERNEL); > - if (!cfg) { > - dev_err(dev, "failed to alloc memory for configs\n"); > + if (!cfg) > goto free_gname; > - } > > /* Prepare a list of config settings */ > for (idx = 0, cfg_cnt = 0; idx < ARRAY_SIZE(pcfgs); idx++) { > @@ -253,10 +247,8 @@ skip_cfgs: > if (of_find_property(np, "samsung,exynos5440-pin-function", NULL)) { > fname = kasprintf(GFP_KERNEL, > "%s%s", np->name, FUNCTION_SUFFIX); > - if (!fname) { > - dev_err(dev, "failed to alloc memory for func name\n"); > + if (!fname) > goto free_cfg; > - } > > map[*nmaps].data.mux.group = gname; > map[*nmaps].data.mux.function = fname; > @@ -647,10 +639,8 @@ static int exynos5440_pinctrl_parse_dt_pins(struct platform_device *pdev, > } > > *pin_list = devm_kzalloc(dev, *npins * sizeof(**pin_list), GFP_KERNEL); > - if (!*pin_list) { > - dev_err(dev, "failed to allocate memory for pin list\n"); > + if (!*pin_list) > return -ENOMEM; > - } > > return of_property_read_u32_array(cfg_np, "samsung,exynos5440-pins", > *pin_list, *npins); > @@ -678,17 +668,15 @@ static int exynos5440_pinctrl_parse_dt(struct platform_device *pdev, > return -EINVAL; > > groups = devm_kzalloc(dev, grp_cnt * sizeof(*groups), GFP_KERNEL); > - if (!groups) { > - dev_err(dev, "failed allocate memory for ping group list\n"); > + if (!groups) > return -EINVAL; > - } > + > grp = groups; > > functions = devm_kzalloc(dev, grp_cnt * sizeof(*functions), GFP_KERNEL); > - if (!functions) { > - dev_err(dev, "failed to allocate memory for function list\n"); > + if (!functions) > return -EINVAL; > - } > + > func = functions; > > /* > @@ -708,10 +696,8 @@ static int exynos5440_pinctrl_parse_dt(struct platform_device *pdev, > /* derive pin group name from the node name */ > gname = devm_kasprintf(dev, GFP_KERNEL, > "%s%s", cfg_np->name, GROUP_SUFFIX); > - if (!gname) { > - dev_err(dev, "failed to alloc memory for group name\n"); > + if (!gname) > return -ENOMEM; > - } > > grp->name = gname; > grp->pins = pin_list; > @@ -727,18 +713,13 @@ skip_to_pin_function: > /* derive function name from the node name */ > fname = devm_kasprintf(dev, GFP_KERNEL, > "%s%s", cfg_np->name, FUNCTION_SUFFIX); > - if (!fname) { > - dev_err(dev, "failed to alloc memory for func name\n"); > + if (!fname) > return -ENOMEM; > - } > > func->name = fname; > func->groups = devm_kzalloc(dev, sizeof(char *), GFP_KERNEL); > - if (!func->groups) { > - dev_err(dev, "failed to alloc memory for group list " > - "in pin function"); > + if (!func->groups) > return -ENOMEM; > - } > func->groups[0] = gname; > func->num_groups = gname ? 1 : 0; > func->function = function; > @@ -766,10 +747,8 @@ static int exynos5440_pinctrl_register(struct platform_device *pdev, > int pin, ret; > > ctrldesc = devm_kzalloc(dev, sizeof(*ctrldesc), GFP_KERNEL); > - if (!ctrldesc) { > - dev_err(dev, "could not allocate memory for pinctrl desc\n"); > + if (!ctrldesc) > return -ENOMEM; > - } > > ctrldesc->name = "exynos5440-pinctrl"; > ctrldesc->owner = THIS_MODULE; > @@ -779,10 +758,8 @@ static int exynos5440_pinctrl_register(struct platform_device *pdev, > > pindesc = devm_kzalloc(&pdev->dev, sizeof(*pindesc) * > EXYNOS5440_MAX_PINS, GFP_KERNEL); > - if (!pindesc) { > - dev_err(&pdev->dev, "mem alloc for pin descriptors failed\n"); > + if (!pindesc) > return -ENOMEM; > - } > ctrldesc->pins = pindesc; > ctrldesc->npins = EXYNOS5440_MAX_PINS; > > @@ -796,10 +773,8 @@ static int exynos5440_pinctrl_register(struct platform_device *pdev, > */ > pin_names = devm_kzalloc(&pdev->dev, sizeof(char) * PIN_NAME_LENGTH * > ctrldesc->npins, GFP_KERNEL); > - if (!pin_names) { > - dev_err(&pdev->dev, "mem alloc for pin names failed\n"); > + if (!pin_names) > return -ENOMEM; > - } > > /* for each pin, set the name of the pin */ > for (pin = 0; pin < ctrldesc->npins; pin++) { > @@ -836,10 +811,8 @@ static int exynos5440_gpiolib_register(struct platform_device *pdev, > int ret; > > gc = devm_kzalloc(&pdev->dev, sizeof(*gc), GFP_KERNEL); > - if (!gc) { > - dev_err(&pdev->dev, "mem alloc for gpio_chip failed\n"); > + if (!gc) > return -ENOMEM; > - } > > priv->gc = gc; > gc->base = 0; > @@ -941,10 +914,8 @@ static int exynos5440_gpio_irq_init(struct platform_device *pdev, > > intd = devm_kzalloc(dev, sizeof(*intd) * EXYNOS5440_MAX_GPIO_INT, > GFP_KERNEL); > - if (!intd) { > - dev_err(dev, "failed to allocate memory for gpio intr data\n"); > + if (!intd) > return -ENOMEM; > - } > > for (i = 0; i < EXYNOS5440_MAX_GPIO_INT; i++) { > irq = irq_of_parse_and_map(dev->of_node, i); > @@ -987,10 +958,8 @@ static int exynos5440_pinctrl_probe(struct platform_device *pdev) > } > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > - if (!priv) { > - dev_err(dev, "could not allocate memory for private data\n"); > + if (!priv) > return -ENOMEM; > - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > priv->reg_base = devm_ioremap_resource(&pdev->dev, res); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/