From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbbFXEzY (ORCPT ); Wed, 24 Jun 2015 00:55:24 -0400 Received: from mail-by2on0075.outbound.protection.outlook.com ([207.46.100.75]:3849 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750770AbbFXEzS (ORCPT ); Wed, 24 Jun 2015 00:55:18 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none; Message-ID: <558A382B.8000601@xilinx.com> Date: Wed, 24 Jun 2015 06:55:07 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Moritz Fischer , jassisinghbrar@gmail.com CC: linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, arnd@arndb.de, joe@perches.com, jingoohan1@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox. References: <1435082402-29239-1-git-send-email-moritz.fischer@ettus.com> <1435082402-29239-3-git-send-email-moritz.fischer@ettus.com> In-Reply-To: <1435082402-29239-3-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21630.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD010;1:RvBT6hWDA4Nn/Zf3dTIKfzW/apK+ALVxTaIN8A9tkcUex6qR3VZUhpLpSO1curk6Fp40AS90OWWX2SdBg+hUXAO8XO/Qc7kcTYUGQpd93zYwii7nJfLI88vrJmlckXveGJFN5yZTQ3a4ixYQJRz9EnVF65aqNRPvCBopc1oMzpDZEatRWGXrvx0MnZfMVJmMac/rgXKru4k+o+m/SSr3KJEFIAxjjXaYSrYBQics1cIv37YVwK3BKU/2qv5HC+NtXT7hHMO3hEeflOv3e56TNg== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(199003)(189002)(51704005)(24454002)(164054003)(377454003)(47776003)(50986999)(65806001)(189998001)(110136002)(63266004)(6806004)(36756003)(86362001)(87266999)(76176999)(54356999)(2950100001)(65816999)(77096005)(83506001)(23746002)(36386004)(50466002)(46102003)(4001350100001)(5001960100002)(92566002)(106466001)(33656002)(59896002)(87936001)(77156002)(62966003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB023;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB023;2:W6s1ZLNDD+z1UDFENf/3ra8Pv7Us6M4cVrHA+pt/NB/xwdi/1ZFme2l4L0X7Hkm0;3:6uzre9Xq+O89cRRncR9gufvBalvp3lapYu2fB9NAm4vu1DqpDPPNrZf//p6NoiVAOLrCoN1PqdkL1zJI10Fjx68/5xrNjagvYwsB/yaCNBux8UW5Bc2U2cVfM4zISsHGmISbMUMrJLcXyTLd5/Es6pi/sEx3no/ba+V/FQMndw5BS7y0JbDVJ4EiyphNWiriCk0m87O6RG6XzUL3RGRhAzI6SzAyBHf8/pSxvXhtQlhYQpndaiogyvuN54LUrlfe;20:S04EVe+Rnj6l9tHczRCexihdbOkcMJY+Kd5gilk+KVauwzkBi/wS+geW9ZvPuMisDld8uuUt0WeOaRq339FfvsdtPjkR9hW3n+EOICPntKaIww4zxp+44pF5ARIBsGleKSwJ64vLpjs3qft7Qx4+6Be0S6XN0ROyTOVulwwJ0ZUjPi6f6h7DDO8FwjLfal1OlFopM11hnWdjTSDaUPzIbG2oOq7zWPFCZZ54O7cskz1163H4lP1eEFeU4YqnMtrLLX9oWx/sMo+MmlFxdYKNpPk88wTbNhISUT+s52OioqYBmSEUilKL4HP60Vg3b7FTm6gJIymp9/69rFUHWW3MMp+AkkLS2MMnSUc2yIWxt8C4BCWRbEXRRnn8Kvzkn70skvpv0ft3F7Ral506KDTBVSl0C+wluP1A9kUm0rLvCAJsAfURI6NETco1HX4CwDmcjiskF96rsxXGd9IiLabCl9k717KkXegBxP2om565X30+LN7+CHPzfvrMRZCFQq2p X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB023; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BL2FFO11HUB023;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB023; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB023;4:GtN9AsMgAtPB5MzTuqNAPOhBjsZ9uHnIUhLoWTHPGcsOZrXKJDFprvyOp71WWPirf5urg4SR0OadT6vzlzDlMHehfJ22c/jXO/zepbyKhS7XsN5yFuCuamrsNlh1NNVJIfsxa8dhOHAxiyH3g6MWXHd4k5FqEhpobx7jSy/YrABklJx7Gpgq2+Ru/AGq2Wr3e/Y/eRW52VXb/68sGpi1zWcqzU7HXLfpT5zjJibuLysxab2AXE3xhJePYFue5tEQCAjRWQ87tMLCGh9zW4mm/p4Y5+3HyxkEJBEJ469BtSs= X-Forefront-PRVS: 061725F016 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2FFO11HUB023;23:pKPlrTK215JFIvdp3i2GFusc2VSqiyvLigSl?= =?Windows-1252?Q?PuWSms5E2oD7jMW77J85wOoH0FzGQ0fBAW9isy64RxTd92LtwtWNwbQI?= =?Windows-1252?Q?84VrPx4Vk+vb/V0uCcGnx0jOOuOGEzwbfrTr7b27sTzw8GjFoTY/es0D?= =?Windows-1252?Q?tu1anzIwzF4SD9r5887+J+4oq6v3hqAY7rusGSh91X4iJ1OJANdyvx0O?= =?Windows-1252?Q?Tpg+HWOP13plhz6p4DpVbdbr2gVJPoavkJl9u97kPpqOznQ3O6oumNGs?= =?Windows-1252?Q?1bRvNtUwYMAiG3L2vG61CRgzTQEbEMY8sOjLnkjanFV/2EOn9nxsX+OP?= =?Windows-1252?Q?OBylqBMENtnDOCdOspmvNbYxf3ZZIWC5rGWw+gTR+Xe3mhlVhWvI+Lr9?= =?Windows-1252?Q?eqW5U++IyAguzmb9fDCw2FExy0MBZGVNnTn9qqjzCalP/At/xo5fyybr?= =?Windows-1252?Q?tSsn1p3xrSj9BhSHHsHgS3+QxAb241pxBv3BhiSq5BnZ82TqNjjt81CH?= =?Windows-1252?Q?gC7jyXHj56VMxo6RmWBz+NP9+iOtfQUMoip0guK8/6P6CG3xv10nBwXS?= =?Windows-1252?Q?54j+OJL+Wo7RTnEogBYK5TA/3ih7l+UAa4rVACpicva+il4gendHGbvI?= =?Windows-1252?Q?aHjkQOJsqIP3yq3CAfnILxzbcUjNy7WniZwzZRsfvlSE+n30eHtr+J8K?= =?Windows-1252?Q?ME5L20gL2ISasui7RhdprBUZg9iMtP1Io7GNY6P1H5bSoM0UvaYqwnYx?= =?Windows-1252?Q?cYPjlTcT5kfWIjuhkLEVO0i9GmkbIbdtLZ53NPzaJYDiVGh+gCUUcINL?= =?Windows-1252?Q?30jfF2Nn3qtDFCqzw8J07Yw3Vv8IB/7J9EuSyewjTy9SJfwwQPX0juK4?= =?Windows-1252?Q?E/ln7zNn0jf8rIkSDAosKJPN9t6leAtvnusMM/fa2IN57MhDOEXGtLdc?= =?Windows-1252?Q?pSCGH11f7SpfLt2C7qKoYp2nKEAZPd9B39BP2cUouiQBVHPXYPOtIA5G?= =?Windows-1252?Q?cR7bNvAQkZUPqjCUoGAmaN54++VWGEolSKjhQrxR3lbvZDJVc0C2H2g/?= =?Windows-1252?Q?G1RloXK8AU11yZPpZKOmAQjEL584gXYJEWwxs8vDFdSLA5ukMCSo5aNd?= =?Windows-1252?Q?sg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB023;5:QruQilYN1gqcQsScXzNPv232uKMyU82O7n3O2z+2JRyaaSK5/+ZRmxZOYTjxTgnVNcV34wQwUZ631b5/2PuxuBqYYS8AcEai/sQwvT7g+pHf4LO4x2uCyCxbcCGXWtYZf55HKCyMOhW008EMudVdHw==;24:okk/R0kAiH2aoHTbFe7m1me/FFoOP4ao+DMNitsmjOhK4EO+B7bF41wfNGzb+jphevAAgdg0CxQF230JWuHzHBMzYDvv6Mf8+UzX3Vh/Dr0= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2015 04:55:15.8825 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB023 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2015 08:00 PM, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is single channel per core and allows for transmit and receive. > > Changes from v4: > - Have separate mbox_ops structs for polling / irq mode > - Moved clk handling to startup / shutdown > - Embedded struct mbox_chan in struct xilinx_mbox > - Misc stylistic issues > > Changes from v3: > - Stylistic > > Changes from v2: > - Fixed error handling for IRQ from >= 0 to > 0 > - Fixed error handling for clock enabling > - Addressed Michal's stylistic comments > > Changes from v1: > - Added common clock framework support > - Deal with IRQs that happend before driver load, > since HW will not let us know about them when we enable IRQs > > Changes from v0: > - Several stylistic issues > - Dropped superfluous intr_mode member > - Really masking the IRQs on mailbox_shutdown > - No longer using polling by accident in non-IRQ mode > - Swapped doc and driver commits BTW: These change logs shouldn't be the part of commit. Thanks, Michal