Re: [PATCH] added device tree support to gpio-generic driver

Linus Walleij
2015-06-10T08:42:47Z

This patch needs to go to the devicetree list too, see To: on this
mail.

On Fri, Jun 5, 2015 at 8:51 AM, Romain Baeriswyl
<romain.baeriswyl@alitech.com> wrote:

> +Required properties:
> +- compatible : "basic-mmio-gpio" for little endian register access or
> + "basic-mmio-gpio-be" for big endian register access

Basic I don't know.

"single-register-gpio" is more to the point, don't you think?

> +- ngpios: Specifies the number of gpio mapped in the register. The value is
> + limited to the number of bits of the LONG type.

So if it is 8 for a 32 bit register, does it mean bits 0..7 little endian or
big endian, or does it depend on endianness? Clarify this
in the binding.

> +
> +Optional properties:
> +- base: Allows to forces the gpio number base offset used to index the gpio in
> + the device. If it is not see then the driver search autonoumously for
> + valid index range.
> +
> +Examples:
> +
> + gpio_a {
> + compatible = "basic-mmio-gpio";
> + ngpios = <32>;
> + };

Yours,
Linus Walleij