Re: [PATCH] added device tree support to gpio-generic driver

Alexander Shiyan
2015-06-05T07:41:09Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 775 bytes --]

ÐŸÑÑ‚Ð½Ð¸Ñ†Ð°, 5 Ð¸ÑŽÐ½Ñ 2015, 8:51 +02:00 Ð¾Ñ‚ Romain Baeriswyl <romain.baeriswyl@alitech.com>:
> ---
> .../devicetree/bindings/gpio/gpio-generic.txt | 19 +++++
> drivers/gpio/gpio-generic.c | 81 ++++++++++++++-----
> 2 files changed, 78 insertions(+), 22 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-generic.txt

Hello.

...
> diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
...
> + if (of_property_read_u32(dev->of_node, "base", &pdata->base))
> + pdata->base = -1;

The "base" property is excessive for DT.

---

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥