From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbbFYAAS (ORCPT ); Wed, 24 Jun 2015 20:00:18 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59811 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbbFYAAQ (ORCPT ); Wed, 24 Jun 2015 20:00:16 -0400 Message-ID: <558B4486.9070802@roeck-us.net> Date: Wed, 24 Jun 2015 17:00:06 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Constantine Shulyupin , jdelvare@suse.de, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix nct7802_temp_is_visible References: <1435186051-10196-1-git-send-email-const@MakeLinux.com> In-Reply-To: <1435186051-10196-1-git-send-email-const@MakeLinux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Constantine, On 06/24/2015 03:47 PM, Constantine Shulyupin wrote: > From: const > > Fixed registers are invisible only when registers' mode is 0 > > Signed-off-by: Constantine Shulyupin > --- > drivers/hwmon/nct7802.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c > index ec56782..65e40c2 100644 > --- a/drivers/hwmon/nct7802.c > +++ b/drivers/hwmon/nct7802.c > @@ -541,13 +541,11 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, > if (err < 0) > return 0; > > - if (index < 9 && > - (reg & 03) != 0x01 && (reg & 0x03) != 0x02) /* RD1 */ > + if (index < 9 && !(reg & 0x03)) /* RD1 */ > return 0; > - if (index >= 9 && index < 18 && > - (reg & 0x0c) != 0x04 && (reg & 0x0c) != 0x08) /* RD2 */ > + if (index >= 9 && index < 18 && !(reg & 0x0c)) /* RD2 */ > return 0; > - if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */ > + if (index >= 18 && index < 27 && !(reg & 0x30)) /* RD3 */ 11b sets a sensor to voltage sense mode, not temperature mode. This is what the inX attributes are for. We can not just display a random temperature value if a sensor is configured to measure a voltage. According to my datasheet, 01b (0x10 shifted) is reserved for RD3. So there is a bug, but it is if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */ which should be if (index >= 18 && index < 27 && (reg & 0x30) != 0x20) /* RD3 */ Can you send an updated patch ? Thanks, Guenter