From: Ian Abbott <abbotti@mev.co.uk>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Santosh <santhosh.pai88@yahoo.com>
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code
Date: Thu, 25 Jun 2015 10:28:48 +0100 [thread overview]
Message-ID: <558BC9D0.1080500@mev.co.uk> (raw)
In-Reply-To: <20150625044005.GC3111@sudip-PC>
On 25/06/15 05:40, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 11:22:24PM +0530, Santosh wrote:
>> try_module_get fails when the reference count of the module is not
>> allowed to be incremented ,and hence -ENXIO is returned indicating
>> no device or address.
> 1) this patch is 2/2, but then where is your 1/2 patch?
> 2) You have used "santosh" in your email From: header.
> use "santosh pai" there. It should be same as what you use in your
> Signed-off-by:
3) Most of the commit message body (apart from the Signed-off-by line)
has been indented by 2 spaces for no good reason.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-06-25 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <558AEE58.1060702@yahoo.com>
2015-06-25 4:40 ` [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code Sudip Mukherjee
2015-06-25 9:28 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BC9D0.1080500@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santhosh.pai88@yahoo.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox