From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbbFYJ25 (ORCPT ); Thu, 25 Jun 2015 05:28:57 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:60238 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbbFYJ2v (ORCPT ); Thu, 25 Jun 2015 05:28:51 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <558BC9D0.1080500@mev.co.uk> Date: Thu, 25 Jun 2015 10:28:48 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Sudip Mukherjee , Santosh CC: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code References: <558AEE58.1060702@yahoo.com> <20150625044005.GC3111@sudip-PC> In-Reply-To: <20150625044005.GC3111@sudip-PC> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/15 05:40, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 11:22:24PM +0530, Santosh wrote: >> try_module_get fails when the reference count of the module is not >> allowed to be incremented ,and hence -ENXIO is returned indicating >> no device or address. > 1) this patch is 2/2, but then where is your 1/2 patch? > 2) You have used "santosh" in your email From: header. > use "santosh pai" there. It should be same as what you use in your > Signed-off-by: 3) Most of the commit message body (apart from the Signed-off-by line) has been indented by 2 spaces for no good reason. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-