From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbbFYRk2 (ORCPT ); Thu, 25 Jun 2015 13:40:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36535 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbbFYRkX (ORCPT ); Thu, 25 Jun 2015 13:40:23 -0400 Message-ID: <558C3D05.4070701@redhat.com> Date: Thu, 25 Jun 2015 13:40:21 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Srikar Dronamraju , Ingo Molnar , Peter Zijlstra CC: linux-kernel@vger.kernel.org, Mel Gorman , Iulia Manda Subject: Re: [PATCH 3/3] sched/numa: Fix numabalancing stats in /proc/pid/sched References: <1435252903-1081-1-git-send-email-srikar@linux.vnet.ibm.com> <1435252903-1081-4-git-send-email-srikar@linux.vnet.ibm.com> In-Reply-To: <1435252903-1081-4-git-send-email-srikar@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/2015 01:21 PM, Srikar Dronamraju wrote: > Commit 44dba3d5d6a1 (sched: Refactor task_struct to use numa_faults > instead of numa_* pointers) modified the way tsk->numa_faults stats are > accounted. However that commit never touched show_numa_stats() that > displays /proc/pid/sched. Now the numbers displayed in /proc/pid/sched > dont match the actual numbers. > > Fix it by making sure that /proc/pid/sched reflects the task fault numbers > Also add group fault stats too. > > Also couple of more modifications are added here. > 1. Format change. > - Previously we would list two entries per node, one for private and one for > shared. Also the home node info was listed in each entry. > > - Now preferred node, total_faults and current node are displayed separately. > - Now there is one entry per node, that lists private,shared task and group > faults. > > 2. p->numa_pages_migrated was getting reset after every read of > /proc/pid/sched. Its more useful to have absolute numbers since > differential migrations between two accesses can be easily calculated. > > Signed-off-by: Srikar Dronamraju Acked-by: Rik van Riel Thank you for updating the statistics to match what the code does nowadays.