From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbbFZKWU (ORCPT ); Fri, 26 Jun 2015 06:22:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:15294 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbbFZKWM (ORCPT ); Fri, 26 Jun 2015 06:22:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,683,1427785200"; d="scan'208";a="753625714" Message-ID: <558D273F.8020108@intel.com> Date: Fri, 26 Jun 2015 13:19:43 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Ivan T. Ivanov" , Ulf Hansson CC: Tim Kryger , Aisheng Dong , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence References: <1435312810-23957-1-git-send-email-ivan.ivanov@linaro.org> <1435312810-23957-2-git-send-email-ivan.ivanov@linaro.org> In-Reply-To: <1435312810-23957-2-git-send-email-ivan.ivanov@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/15 13:00, Ivan T. Ivanov wrote: > Controller could have BROKEN_CARD_DETECTION quirk set, but drivers > could use GPIO to detect card present state. Let, when defined, GPIO > take precedence, so drivers could properly detect card state and not > use polling. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/mmc/host/sdhci.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index bc14452..8bafb9f 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1601,15 +1601,18 @@ static int sdhci_do_get_cd(struct sdhci_host *host) > if (host->flags & SDHCI_DEVICE_DEAD) > return 0; > > + /* > + * Try slot gpio detect, if defined it take precedence > + * over build in controller functionality > + */ > + if (!IS_ERR_VALUE(gpio_cd)) > + return !!gpio_cd; > + You've also put it above the MMC_CAP_NONREMOVABLE check which doesn't seem right. > /* If polling/nonremovable, assume that the card is always present. */ > if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) || > (host->mmc->caps & MMC_CAP_NONREMOVABLE)) > return 1; > > - /* Try slot gpio detect */ > - if (!IS_ERR_VALUE(gpio_cd)) > - return !!gpio_cd; > - > /* Host native card detect */ > return !!(sdhci_readl(host, SDHCI_PRESENT_STATE) & SDHCI_CARD_PRESENT); > } > -- > 1.9.1 > > >