From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbbFZT4O (ORCPT ); Fri, 26 Jun 2015 15:56:14 -0400 Received: from mout.web.de ([212.227.17.11]:64256 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbbFZTz5 (ORCPT ); Fri, 26 Jun 2015 15:55:57 -0400 Message-ID: <558DAE45.1030802@users.sourceforge.net> Date: Fri, 26 Jun 2015 21:55:49 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnaud Patard , Greg Kroah-Hartman , devel@driverdev.osuosl.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] staging: xgifb: Delete an unnecessary check before the function call "XGIfb_search_crt2type" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/nhTdWfKbjHXLF6Lpq9dUM2N7VBYItZamUGFmFW1/lkwAxdQ6O2 loSia3zc3gLGLvBIYYCoZD3dIMUicN1hd8I+PuaFiz7txlnyYZOdQytrLqstVoqeR1mbkom 2WLCJLbLkNaTSYPzM9dfe6kbgjsZzhra3deVZA6MG0kGfSPNhXp4Ma5rPy6bnq619j1ex44 55Yehyc4GeCG0XJkmN2lg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0tEH6ImsrZE=:6MF9A5lfq4S4XyoAbWYdys r3jJi5jw3v/bpvojnfWoJC+2rUlPxhyGJO3lUBoD8x3rNvMu8STj2/gIWEpJgBKxak+Tc09iD 5HukkmotTCFT+nqg98h4kWeVLrp98V6IOriGm528m3oGsyaN/CUWYW9EpuXNnZcdDW6Mx9+dj zu46ECKapwlqL+qqjF/jQK0a5dhKly05o0ZmTYxR9Invq/+mtla+h18gDmJyaLHBl7zxAUhbJ 7KnWWVNWtpHfTtOc4kmVFtEcmS3qXpbj7Xw4WzMCA3JnoHXP7ev2+Jf82tNYTWF8oHZX3FKiI jGsN3OYz1bececwCCZ1XeETwnVbyZKkOOnwRHdBo5yRCAT7P+BnNdr+fhIuvdPeJuxx/Zl74m rOeDG/romQPdhUfSb8E4SJ3nX4KgtZPHHh5hvoyFJVBNAg0Ct/YJwzHOewdebzVA5S7y5UrBX TnkO1vk40ay5JtBAbPhpW750t2QW//IuiH4LZTIt/aJ4BjoYFTZWuhCA00QMNzhrwMwVnJQbf dQ2l2FbTxKfzXIIwR9I7hiWLQTh22R15ZiGVLYI3V3BaC2tz9VyBbXRtvLXqnVRs/zSYMl1QD B7tsBGSCwEC3s3czitGcQ6a15GEoXM+8O8jJ19UAdOfpXMh9+OOOllHIlkCaI904jLr9uqGAE arMcFQF81yYrnLs19Zupi+klSgsCOLGAMzdCdfTWXfJNll1TpeG/ZLYqAyT2kkeVavDY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Jun 2015 21:50:41 +0200 The XGIfb_search_crt2type() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/xgifb/XGI_main_26.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 943d463..ee0906e 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++ b/drivers/staging/xgifb/XGI_main_26.c @@ -2090,8 +2090,7 @@ static int __init xgifb_init(void) { char *option = NULL; - if (forcecrt2type != NULL) - XGIfb_search_crt2type(forcecrt2type); + XGIfb_search_crt2type(forcecrt2type); if (fb_get_options("xgifb", &option)) return -ENODEV; XGIfb_setup(option); -- 2.4.4