From: Pan Xinhui <xinhuix.pan@intel.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, linux@rasmusvillemoes.dk,
tj@kernel.org, mnipxh@163.com
Subject: [PATCH] lib/bitmap.c: add some check to correct the parse result
Date: Sat, 27 Jun 2015 14:36:18 +0800 [thread overview]
Message-ID: <558E4462.7060600@intel.com> (raw)
Sometimes the input from user may cause an unexpected result.
for example, echo "1-3," > /proc/irq/<xxx>/smp_affinity_list.
The correct result should be 1-3, however we got 0-4.
To avoid this issue, we check if there is a ready digit.
If no valid digit is set, we just continue to the next parse.
Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com>
---
lib/bitmap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 64c0926..3c489c1 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -561,6 +561,8 @@ static int __bitmap_parselist(const char *buf, unsigned int buflen,
return -EINVAL;
if (b >= nmaskbits)
return -ERANGE;
+ if (unlikely(exp_digit))
+ continue;
while (a <= b) {
set_bit(a, maskp);
a++;
--
1.9.1
next reply other threads:[~2015-06-26 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 6:36 Pan Xinhui [this message]
2015-07-09 22:57 ` [PATCH] lib/bitmap.c: add some check to correct the parse result Andrew Morton
2015-07-10 6:03 ` Pan Xinhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558E4462.7060600@intel.com \
--to=xinhuix.pan@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mnipxh@163.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox