From: Alexei Starovoitov <ast@plumgrid.com>
To: He Kuang <hekuang@huawei.com>,
rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com,
mingo@redhat.com, acme@redhat.com
Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: Put perf_events check ahead of bpf prog
Date: Sat, 27 Jun 2015 00:55:10 -0700 [thread overview]
Message-ID: <558E56DE.4070006@plumgrid.com> (raw)
In-Reply-To: <1435387495-141813-1-git-send-email-hekuang@huawei.com>
On 6/26/15 11:44 PM, He Kuang wrote:
> @@ -1141,13 +1141,13 @@ kprobe_perf_func(struct trace_kprobe *tk, struct pt_regs *regs)
> int size, __size, dsize;
> int rctx;
>
> - if (prog && !trace_call_bpf(prog, regs))
> - return;
> -
> head = this_cpu_ptr(call->perf_events);
> if (hlist_empty(head))
> return;
>
> + if (prog && !trace_call_bpf(prog, regs))
> + return;
I considered doing that before placing it where it is now.
There were some issues with this approach. Trying to remember.
I'm traveling at the moment. Will elaborate next week.
next prev parent reply other threads:[~2015-06-27 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 6:44 [PATCH] bpf: Put perf_events check ahead of bpf prog He Kuang
2015-06-27 7:55 ` Alexei Starovoitov [this message]
2015-06-27 8:52 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558E56DE.4070006@plumgrid.com \
--to=ast@plumgrid.com \
--cc=acme@redhat.com \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox