From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754132AbbF0MLE (ORCPT ); Sat, 27 Jun 2015 08:11:04 -0400 Received: from mout.web.de ([212.227.17.11]:58516 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbbF0MKw (ORCPT ); Sat, 27 Jun 2015 08:10:52 -0400 Message-ID: <558E92BA.2090101@users.sourceforge.net> Date: Sat, 27 Jun 2015 14:10:34 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , H Hartley Sweeten , Ian Abbott , devel@driverdev.osuosl.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] staging: comedi: adl_pci9118: Delete an unnecessary check before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:plr8azuddpt8s/2FTkvLHp8Xb1Awv89UgrTfo+Hs974T27d5MZG 25gpacTHO1gbNHBa5LorP3sJYK6WQsoO7my85l3xY7WpJwMcka24U3FUbYRfDmQfC7KK0X7 ppJYx9oCZPqXHmwX7T5mUAivRQpSjSonnmJB1dvJBH18AnqMln+cBveH5DbhIPkDIo+ePKd eAtZHuDsHe5csG83YkJsg== X-UI-Out-Filterresults: notjunk:1;V01:K0:EglrF94sxOk=:CuMWSO8ASyJMWtLuk6OQQC WCvNqPheBwOPEa6MaonV3TdsLM3OjNDNtIJ4qyjjmRzU5diZHfkN34sbqVEmqNNSOgS7ZLylN qVf9Bf0ahTrXXr9mm1BzD7snvh0ZDW3LDWkyI5c+EK3bgp/KS4f1srKQrAldZom/Jjw2c9L7x 7zADbrf2pkdxg/TffMVXHUpqlC71DG/RGpE4FotWH2cO8fp4WLt3vXjmLZVU1iSEM7QgOlG0t hfFp7tNYD48lmsxI+QvwdWcIEULdsMam3bC1s4QAh2MMx5HFI4p/cI6yjuepN4SxwOWMxDLye KXOAG8pIosZ93U+9Vc4qVuNLgYq8den0QDpRzwmSLQ9RPHDanFAEVNafbj6lSd8nEBL/CtBZv ldyfFVYYJ8ThAQp2dO/WwgkmsADwUwpWy4C27wWg8SffA/vBEQLKX/eEswjfV2sgNb6gwjfJM QZbVWaeOwSmEPyqKg7RfFEO3pW/fy/epdXy7UekDcAr5K7YqaqYV+SEODbBaJunF+peX6vCfS X8kgtCNhCL4mnjTFbJMAAKqMn1mDaVB2CTb0wDEPtGs7itq/HPwUSQvnVd7/3F/L2CjOzsRfF rv/KzFr6IbZIgjq5dvKZey2ubXgMamVaZPGSYF4RybV1JIYKbIQZJtjyP7yAJfmRTb4vaVaat BI7EGMNMsgzjhmE2LZziaxNIf4EqR031n5ejcvRqxs+3YdXJS3w8T4InhOhDITEOlwPc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 27 Jun 2015 13:50:43 +0200 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index fb3043d..19b5806 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -1717,8 +1717,7 @@ static void pci9118_detach(struct comedi_device *dev) pci9118_reset(dev); comedi_pci_detach(dev); pci9118_free_dma(dev); - if (pcidev) - pci_dev_put(pcidev); + pci_dev_put(pcidev); } static struct comedi_driver adl_pci9118_driver = { -- 2.4.4