From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbbF0Qiv (ORCPT ); Sat, 27 Jun 2015 12:38:51 -0400 Received: from mout.web.de ([212.227.17.12]:60658 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbbF0Qil (ORCPT ); Sat, 27 Jun 2015 12:38:41 -0400 Message-ID: <558ED18A.7030407@users.sourceforge.net> Date: Sat, 27 Jun 2015 18:38:34 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Airlie CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] agp/intel-gtt: Deletion of unnecessary checks before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546C9B12.5070800@users.sourceforge.net> In-Reply-To: <546C9B12.5070800@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:af/AsoVRluP7Qk5k8xtk/gG7MbVtCJk4jyt65zWncSMptptyRcQ cBCx0t9j5Qv5r4XOV+uhzH/j0BuHIljuQOieXS3UrzCbwWh6NDFjRLiQDYWu5suQsgH9wVN mt7FWkXMwQdbv9zy8bXG95AJLLAJj+68O/DkLgYk4vfBwMBfVAZ9hEAANIAZTdPNKPGVNWW bu6/O3mbrjJiUf2GKRlAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:2OnezkUOb5A=:0GQCQ+APexDyiKaSh7nZDu oSXusFRFC76ui559la268BaV9swYyhnKKAT92aw3iKu8N7ggKnaIn+yK3/Q3ESo6W6EshUzdM UFg59zne1ehQmi0PVH7+5aLR/C6WWXl9At4TxE06nEkDqjEE3X3F6vY9zNTz+b/zIiTspj8oO YtImSRc9lW6S76tJ8OOqF10/sb3DEBVYE5VDHmukrse/XNgvUWs60YSWW94s/wO3qaQJ/F2J/ khG9PxODw3bQ9fnQtHQDUTtVL66hDpET+iZ7XHoX+HR7NRXjwKhskNDKzF4VR6nWaTj0pCUF9 ++1IMzTzBHJuhngQQupe0yESwRyGGxJmllYv8HTxwf+sma8zoeE1G7eyCdKcCzLs2UoZ2y/SM ZJlXIKo7N4KC62iW7koM9bDyDmWFVQ3NOFnEqmVM2Ci0nTcmlsedz+6d1zdaJCslAcBnE6KN2 YXWw3lxPU+klAxz38Fz3D+OZ2e+LVQ5YzvJKPFVHiMs51Q1x/2VxZe3CaGCdX/FH5GbwOwGnx c2B0GB3wvBn5yoF1iw9/XrsjkwbALAahOZ3bfgQtMG6Ylv2l28LHFHf0OESXePeUvCbu2UynC y5mbF0Kx5qy68ZdUO0L7Y7PcFPpn5MIAqODwxYwhZ3V9QmNNFE9v4J/vbO+j8igGZ0lr+fBQn B7uBhCdenEyGm18mEOK5M40WlrP7oHWoJRytT27exFWzuU+XCd1JUYlsZy1T2pX80aF0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Wed, 19 Nov 2014 14:24:20 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/char/agp/intel-gtt.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c > index 9a024f8..db5877e 100644 > --- a/drivers/char/agp/intel-gtt.c > +++ b/drivers/char/agp/intel-gtt.c > @@ -1434,10 +1434,8 @@ void intel_gmch_remove(void) > if (--intel_private.refcount) > return; > > - if (intel_private.pcidev) > - pci_dev_put(intel_private.pcidev); > - if (intel_private.bridge_dev) > - pci_dev_put(intel_private.bridge_dev); > + pci_dev_put(intel_private.pcidev); > + pci_dev_put(intel_private.bridge_dev); > intel_private.driver = NULL; > } > EXPORT_SYMBOL(intel_gmch_remove); > Would you like to integrate this update suggestion into a source code repository? Regards, Markus