From: Jens Axboe <axboe@kernel.dk>
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix bogus EFAULT error from SG_IO ioctl
Date: Sat, 27 Jun 2015 11:43:48 -0600 [thread overview]
Message-ID: <558EE0D4.9070201@kernel.dk> (raw)
In-Reply-To: <1435311886-30834-1-git-send-email-pbonzini@redhat.com>
On 06/26/2015 03:44 AM, Paolo Bonzini wrote:
> Whenever blk_fill_sghdr_rq fails, its errno code is ignored and changed to
> EFAULT. This can cause very confusing errors:
>
> $ sg_persist -k /dev/sda
> persistent reservation in: pass through os error: Bad address
>
> The fix is trivial, just propagate the return value from
> blk_fill_sghdr_rq.
Added, thanks.
--
Jens Axboe
prev parent reply other threads:[~2015-06-27 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:44 [PATCH] block: fix bogus EFAULT error from SG_IO ioctl Paolo Bonzini
2015-06-26 14:09 ` Jeff Moyer
2015-06-27 17:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558EE0D4.9070201@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox