From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755292AbbF0Roi (ORCPT ); Sat, 27 Jun 2015 13:44:38 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44907 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbbF0Ro3 (ORCPT ); Sat, 27 Jun 2015 13:44:29 -0400 Message-ID: <558EE0F5.7040804@fb.com> Date: Sat, 27 Jun 2015 11:44:21 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Geert Uytterhoeven , Alexander Viro , Tejun Heo CC: , Subject: Re: [PATCH] bdi: Remove "inline" keyword from exported I_BDEV() implementation References: <1435319912-4335-1-git-send-email-geert@linux-m68k.org> In-Reply-To: <1435319912-4335-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-27_02:2015-06-26,2015-06-27,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2015 05:58 AM, Geert Uytterhoeven wrote: > With gcc 3.4.6/4.1.2/4.2.4 (not with 4.4.7/4.6.4/4.8.4): > > CC fs/block_dev.o > include/linux/fs.h:804: warning: ‘I_BDEV’ declared inline after being called > include/linux/fs.h:804: warning: previous declaration of ‘I_BDEV’ was here > > Commit a212b105b07d75b4 ("bdi: make inode_to_bdi() inline") added a > caller of I_BDEV() in a header file, exposing the bogus "inline" on the > exported implementation. > > Drop the "inline" keyword to fix this. Added, thanks. -- Jens Axboe