From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbbF1JVu (ORCPT ); Sun, 28 Jun 2015 05:21:50 -0400 Received: from mout.web.de ([212.227.15.4]:64365 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbbF1JVn (ORCPT ); Sun, 28 Jun 2015 05:21:43 -0400 Message-ID: <558FBCA0.2090206@users.sourceforge.net> Date: Sun, 28 Jun 2015 11:21:36 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] ALSA: hda: Delete an unnecessary check before the function call "snd_info_free_entry" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ZS+xx8q/7F7dfI4vk+fWnn/R+IjgWXys6Jh4UcKGCMIuRc0bH71 jcLjXz9rAIMizhMo+7DNO848Qkw74lynELzaa036TIzWgVX0+cxC7P4AHwXQAGn7oBvLCm+ WkT7joNx0krL89kFQMLr73k7HaE7Tv+CWG+d3cWjioGWGDZnuc8OBpLLZcTrhkm08GDh2Wn j046/1Or1t2ulPTyCNRXQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7bTas5UItQ0=:idsvAhUHn5U982i0ix1FBx 5gJfM/PGYvhfKX30pN+IDJAo1L5CuiUkUZN0ja+hV5xMfZCDVphjHRU3eZep2ExoRNPnfyCAw G2O/jH+Dzdeyl1MX4dvc14ZqBRheSOLG8uQBXHvL0JFzL8z5q7QM+VrSTeljGNitONIKvyFEy QZAYDBw7l3Ta90nQOp43c9Cpi7ZpIe1ip7LRGCBHeakmbkMPdTqn1yYpaWqICPVICWMtxbL6K YIaUp60zfMWUH75Xy5dxw6vNzBBpiNZvnRe/2slbl5o/oboSd/D13ED7uxFma5+KpVnfj2l+e x1X9bztVpvdLRVmx1PD3dsgTfT69s0DHqd4YBazzoOUL4wwEuIVUoJuSUhV0PMt3Rz3ACMCYl UH71AhR+0Ldv5WF+TJrLDifKLJ1Hk4wS0BO5dYM8uXUfgoEIO5txbu/eOdJ2Z8SFl6jzF8Uh2 MdapdXtjZvJvUdxJ5YIGlZoBvz9xHCYK1ga4IS4L/MYgOmEVuTbhz1WvF/4P0JYIGrrO1aB1u nbMG/eNMW3mMU7muFk5NQ1EiSNNmGs+hHDslFLJJLlw5+oo7cGZDU6+ZGiBVu5ne9nzwP6ZoW rCgK82EmLD9gQ+QAh1Pwkop26Rwx8vX9u9BQOO0+uD9MrODt45h/HrzYn1Mb2wM9ojiTj8VvY ZM0iu6AsxlP39/6cDvQdfHlo6jYm5M+EHTUKI5WEqn1FKHV7c3pDOEz7useu7NSEqEX4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Jun 2015 11:15:28 +0200 The snd_info_free_entry() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/hda/patch_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index f852734..2f24338 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -591,7 +591,7 @@ static int eld_proc_new(struct hdmi_spec_per_pin *per_pin, int index) static void eld_proc_free(struct hdmi_spec_per_pin *per_pin) { - if (!per_pin->codec->bus->shutdown && per_pin->proc_entry) { + if (!per_pin->codec->bus->shutdown) { snd_info_free_entry(per_pin->proc_entry); per_pin->proc_entry = NULL; } -- 2.4.4