From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbbF1Lab (ORCPT ); Sun, 28 Jun 2015 07:30:31 -0400 Received: from mout.web.de ([212.227.15.4]:60504 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbbF1LaX (ORCPT ); Sun, 28 Jun 2015 07:30:23 -0400 Message-ID: <558FDAC5.8020902@users.sourceforge.net> Date: Sun, 28 Jun 2015 13:30:13 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joshua Morris , Philip Kelleher CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] block-rsxx: Deletion of an unnecessary check before the function call "vfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547CB26E.6060500@users.sourceforge.net> In-Reply-To: <547CB26E.6060500@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PG4624I+DmcXbLUcLZtZWeoh89gUQRmGITah1p1xyB4jYpqYw6M JPo8EuBF2jz5+GiroPv81Lbpt/tpNHPP3yKvgih+A709q0nK9P1DHGcHK8FJsfDwGmrZKcy 5THQI64FWFybJwg6ECTIoErzsor3fCDeY2ReYUoLdGfwg4/+Oxeaaxy0TafWC3hdoVgiER/ hoeBdEsOHlxnuSxlZX0UA== X-UI-Out-Filterresults: notjunk:1;V01:K0:I+n9T+YBIus=:ctOkA9wBzsDg2LgNRhLnvr 4HJffBGaZKmwLunT5XM2UsKMBno8spPR3BNt662UhF9uG384QN0d2YwOuozbTABvc+gbgiCJJ EdqYRiwje/g94EZP89gtnTxi4QdJVNs9yOlvQJ3Ge4VeJCrzYY0smfh0PO4u5l/pxV8YKaxjo ZHvHGoErH/Jxjl40uF9pJjlPxrD8vYWuS1+ddHRu3JI2HknDMYz8MgFi+rJZwfWpptPX2sZHF YxtoBkl1i53TsRamnl9ApX9HeI0xPSICQQbvMTTaLGzUsB3bi57/lDjRdjcMnFuEqXYxM3nAQ /l+qyKF+gZiFFIahD9eLCnPSbEkDFPTtV3F9oGLnJ9KKwoFzNH5s64c1aFrgtX/6+wJ1KhMPq 6TMLihlO5KCboo+ImJQ9NKOqoBViazRjreTbyPHzjOWFnQc3Wx4ElIXKGzyDG9dsIVPIgTIFF HjAg3WZXHeqgvQt4CMyrJSUya73qm5llnA/NDx5rWHDEpNd1SRTlTu4Ow5xROyvh/D0Bb8m0V EDgb66CkhF+wJPZHSseP3RkIi994I2PYX3esreNKtdj4qT0z+n479CIWP5waUJzcEEQyniZyj uV5YDmzeOorvyScPgPMLgmDgrByh+cKwkoHNjAXHAb29xJndRdD1Vmy1uGuNxwKzBzdNQ9YTP RzrHH6QS8A18GdE1Fli3jc5iOYfizVHnTi+hlsXnR1f9zth36H/7i+6yQ749JPjPf21o= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Mon, 1 Dec 2014 19:19:25 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/block/rsxx/dma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c > index cf8cd29..0181387 100644 > --- a/drivers/block/rsxx/dma.c > +++ b/drivers/block/rsxx/dma.c > @@ -960,8 +960,7 @@ failed_dma_setup: > ctrl->done_wq = NULL; > } > > - if (ctrl->trackers) > - vfree(ctrl->trackers); > + vfree(ctrl->trackers); > > if (ctrl->status.buf) > pci_free_consistent(card->dev, STATUS_BUFFER_SIZE8, > Would you like to integrate this update suggestion into another source code repository? Regards, Markus