From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbbF1MHy (ORCPT ); Sun, 28 Jun 2015 08:07:54 -0400 Received: from mout.web.de ([212.227.15.14]:52980 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbbF1MHp (ORCPT ); Sun, 28 Jun 2015 08:07:45 -0400 Message-ID: <558FE386.7060704@users.sourceforge.net> Date: Sun, 28 Jun 2015 14:07:34 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lee Jones , Bryan Wu , Jean-Christophe Plagniol-Villard , Jingoo Han , Tomi Valkeinen , linux-fbdev@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH v2] backlight: lp8788: Deletion of a check before backlight_device_unregister() References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54720DEB.4060109@users.sourceforge.net> <20141124101006.GD4241@x1> <5473736F.8070705@users.sourceforge.net> In-Reply-To: <5473736F.8070705@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tTLkiWHGXEkeuRI8I/JhOa+fc9Uq8fJxhELv4ebX0w+cwZE54C1 +Y5w+H07zOVChVunD0CFvOXZ48dVXVr5o2GC/ycRCvWtfUPQ+t249mGwhVhdhbM5RQYCuLJ uBdxE85gRXxLJidU50TDrnuSLZ1hjcn6sIUEkykr32WOwNmxXjOzEZKMNlWPYIK/PZYcYOj 2VkfUlCIJQ8yEi/ltCI+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:YDIbf5P985o=:97GA0mCM+xculJbZZ5j8dd x6gsOMkg19vXpL72mOYe+ZG8BejIj+YhMU/mftTOeEs6heVbmECriWaBsroLE65dHkZamG20I Sxt7sQSNQ3f55zxPzCM5pv/75xY1lgI1uIw7u18mPKYis7CRZU+BpFPqvbKBKkMtqoEFljJxX 98HSqWOb8XZO8HHNtPExNQ+NJ5Hk6H2iSAvTNqp94z4mbzb4cUoRO7n0eqZSp6zWQGYcPfNNl loP+TG74czcfTHA+95mmwXc71jihpvXVIz9Ak2ttBOj4fRAwpcAqtBIzeizEjhL21XRzVDZOh xaw+8kfV1jv7gfIkfLuZFx8J7mDcz0s9EfNF8LGcv2RFtxqlpelGOzOaRIjD1XSns7UhqfxtM cl1trbCGGGUPgHTgxfza74p+/Ei95xsYekAZD3Uj1tRhXHDwfvxxJKnK+U96OYDuxtYrnL0J5 w1T3hBbx04KhGhTTmQ+DBtVi2XBJ9G3da5yUZCAo418biKAIxz945EpFp5QOTviegkw/kScrs ASA7hYZQ4CBXLuOYx+ljxbu2bm+B+EysAjTqw17NOYkm6vkZQTnZk92A/nqwO76hPNZRXGM63 dxcjFRGQ1W9h+mudHKzduNV08x95QoCij7rcCeW7XSnjQPtFYsYp0/EigiUEP/Ghl6xukcC9k ENP7AySKIS5OGLf0xhSrZz9X5g/Y/qhHXRN6vVevoEfXrdNa4i7g1sYAhO4O6hP7fgbw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > > The backlight_device_unregister() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/backlight/lp8788_bl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c > index d6c4f6a..24a055c 100644 > --- a/drivers/video/backlight/lp8788_bl.c > +++ b/drivers/video/backlight/lp8788_bl.c > @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl) > { > struct backlight_device *bl_dev = bl->bl_dev; > > - if (bl_dev) > - backlight_device_unregister(bl_dev); > + backlight_device_unregister(bl_dev); > } > > static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, > Would you like to integrate this update suggestion into another source code repository? Regards, Markus