From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbbF1NJU (ORCPT ); Sun, 28 Jun 2015 09:09:20 -0400 Received: from mout.web.de ([212.227.17.12]:49381 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbbF1NJL (ORCPT ); Sun, 28 Jun 2015 09:09:11 -0400 Message-ID: <558FF1EC.2060605@users.sourceforge.net> Date: Sun, 28 Jun 2015 15:09:00 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , Johan Hovold , linux-usb@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] USB-mxuport: Delete an unnecessary check before the function call "release_firmware" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:kN4AMJzPvQZFP0Yb++OwGbAsML3X7c8Y7FA/uM89Tr5jx0YDoIo uJjtofFdVYHb8lwVnHEIVejL0jCxD0eOR1MuCC+CLpNFFHVm9LNwAAEO+QeW9lVBg6fXss0 ZfA8xEq0QmILW2BAMMWcqUeS7smgX3Ja/K2dSayLERr7puD+tDwoCKoLtfP1tQXJQ4u8zhh dxGTzBYpTWW1j8G2dMkCA== X-UI-Out-Filterresults: notjunk:1;V01:K0:gOqzRXf/8xA=:ewASdDhwkOE5kE9nkWk6H/ oS/tV7+IO/4bu+yG5p/E1kKpvEjI2hnf3yDe0DWP4MY5Y4aUNVk0tPyucqHdK43HohfMRWh/e e2pzDknekUweDW0/bhoWpjZiy/PKyc7JkOUnv2VMALxiXzds8MUUh9m9v36+taGtqP1xw7fy/ 54qboX8TmP9uz1hXfHnuiPwkYUjcDW0b7EqnReosOZLiJyNoRpaGMX+M3Zz3aIL8sZCnG7+7G fZhjcmNW5CypvHxVjzYWGmr/VcmWrFVJAPrV+5hdSXssucIep7nniZ62JAqbiFrOGwWqeQcqQ 4IEAnZ0yBCsivczDE2apwMy7/MxlrxVUv9rroapPdJYz+JoTo2Ptq0tL+YEcKRoV0PDg/R14A 6z76G8oD2fag/FrwzH4bG6FCUZDUlHPDRbEbjQeu73vkiUFCBe9KlIlhPRo68CrYHNg4TPaPj GL0JILasKoB7Qg8rQ006CKNqELaQjD+AGIb1X0r+8VjF5xdf804pnacOTCmhJOJgaLyvg7RTE iipWQgYDTJ6BRteRnruubYykgiYoK6gtYYr/c82pTSWF1TCIa7BQ/wFJNbO1oXtOvFrY+V36T 19ltsLUxnw1ye+v2vliKRJvFnIklxDg6sFMXsCeB07d3xsigyt45sGsqBRabU93rw02Mt52e6 Fs34SyKWPLAPRU4OEJ5yrmh9G6zYI/UTsZ/IeE2TokIsKJ3fkPCFS2h6l/UG1CM4K8+g= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Jun 2015 14:59:04 +0200 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/serial/mxuport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index 460a406..92f7aee 100644 --- a/drivers/usb/serial/mxuport.c +++ b/drivers/usb/serial/mxuport.c @@ -1101,8 +1101,7 @@ static int mxuport_probe(struct usb_serial *serial, */ usb_set_serial_data(serial, (void *)id->driver_info); out: - if (fw_p) - release_firmware(fw_p); + release_firmware(fw_p); return err; } -- 2.4.4