From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbbF2Btm (ORCPT ); Sun, 28 Jun 2015 21:49:42 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:39111 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbbF2Bte (ORCPT ); Sun, 28 Jun 2015 21:49:34 -0400 X-AuditID: cbfee68e-f79c56d000006efb-78-5590a42b849a Message-id: <5590A42B.6050207@samsung.com> Date: Mon, 29 Jun 2015 10:49:31 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Guenter Roeck Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Ramakrishna Pallala Subject: Re: [PATCH] power: axp288_charger: Fix broken extcon API calls References: <1435367564-12900-1-git-send-email-linux@roeck-us.net> In-reply-to: <1435367564-12900-1-git-send-email-linux@roeck-us.net> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkQFd7yYRQg7+XNSwmPXnPbDFx5WRm i8u75rBZfO49wmjxZOEZJouFb24yWZzeXeLA7rFz1l12j80rtDwW73nJ5LFpVSebx87vDewe nzfJBbBFcdmkpOZklqUW6dslcGV09W9gLVguXPGw8yRzA+NKgS5GTg4JAROJrxtnMELYYhIX 7q1nA7GFBJYySsw5mwpTs2XeXaA4F1B8EaPE7IPPmSCcB4wSO/Y8BevgFdCSmHR5JyuIzSKg KrF/0RdmEJsNKL7/xQ2wGlGBMImV06+wQNQLSvyYfA/MFhFQk2g+1QK2gVngE6PElo7NQAkO DmEBd4lj8/QgLnKSOHjjNNh8TgFnid0v/rGD2MwCOhL7W6exQdjyEpvXvGUGmSMhcI5d4tPq 5YwQBwlIfJt8CGymhICsxKYDzBCfSUocXHGDZQKj2CwkJ81CMnYWkrELGJlXMYqmFiQXFCel FxnpFSfmFpfmpesl5+duYgRG3+l/z/p2MN48YH2IUYCDUYmH98PCCaFCrIllxZW5hxhNga6Y yCwlmpwPjPG8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4 pRoYOTM9et1Tpt0JOJcgV7rx5JyUYMnSO+kPg1NydqVM4OM4c65+T0LtyaprH3SnfNwd1vdm vw3Tv8Y/e1+0fJj8zC/UuH7idA6NG1babycFfHx/8VHf+uaD4k8Z13oy9aZ/uqPmcPHac92u yF2dzeem7ZNn0l01P13GeUptZcaO+MaPXU9SaswllFiKMxINtZiLihMB32ivErkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t9jAV3tJRNCDWY8VrKY9OQ9s8XElZOZ LS7vmsNm8bn3CKPFk4VnmCwWvrnJZHF6d4kDu8fOWXfZPTav0PJYvOclk8emVZ1sHju/N7B7 fN4kF8AW1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuW mQN0ipJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYxo6t/A2vBcuGKh50n mRsYVwp0MXJySAiYSGyZd5cNwhaTuHBvPZDNxSEksIhRYvbB50wQzgNGiR17noJV8QpoSUy6 vJMVxGYRUJXYv+gLM4jNBhTf/+IGWI2oQJjEyulXWCDqBSV+TL4HZosIqEk0n2oB28As8IlR YkvHZqAEB4ewgLvEsXl6IDVCAk4SB2+cBpvPKeAssfvFP3YQm1lAR2J/6zQ2CFteYvOat8wT GAVmIVkxC0nZLCRlCxiZVzGKphYkFxQnpeca6RUn5haX5qXrJefnbmIER/cz6R2MqxosDjEK cDAq8fBGpE8IFWJNLCuuzD3EKMHBrCTCm1sAFOJNSaysSi3Kjy8qzUktPsRoCgyBicxSosn5 wMSTVxJvaGxiZmRpZG5oYWRsriTOezLfJ1RIID2xJDU7NbUgtQimj4mDU6qBUazoZVDMrFNn 32ysurDo0oaO7/aGv6UrnN5LmxTdTYxx7LiXI8vObbBzVfA6u5+Xu2M/bdxxw/Zx8V0Rh0sx BvryU2Vk/yVe36k/Q3Bf0HTFCSwqNU8rgwv15WRfLjRy5MlLEKj01zp4WCq9/2hV28Z+tj3P RLfO8VXy/rVC+v1kpvyNXfXOSizFGYmGWsxFxYkAqQTGPwQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, The similar patch[1] was already merged. [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4b703b1d4c46ca4a00109ca1a391943ec21991b3 Thanks, Chanwoo Choi On 06/27/2015 10:12 AM, Guenter Roeck wrote: > The extcon API calls have been changed to add an additional argument. > This causes build errors such as > > drivers/power/axp288_charger.c:851:2: error: > too few arguments to function 'extcon_register_notifier' > > Fixes: 73b6ecdb93e8 ("extcon: Redefine the unique id of supported > external connectors without 'enum extcon' type") > Fixes: 046050f6e623 ("extcon: Update the prototype of > extcon_register_notifier() with enum extcon") > Cc: Chanwoo Choi > Cc: Ramakrishna Pallala > Signed-off-by: Guenter Roeck > --- > drivers/power/axp288_charger.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/axp288_charger.c b/drivers/power/axp288_charger.c > index 5680317f4823..0aa6e7fd25d4 100644 > --- a/drivers/power/axp288_charger.c > +++ b/drivers/power/axp288_charger.c > @@ -848,7 +848,8 @@ static int axp288_charger_probe(struct platform_device *pdev) > /* Register for extcon notification */ > INIT_WORK(&info->cable.work, axp288_charger_extcon_evt_worker); > info->cable.nb.notifier_call = axp288_charger_handle_cable_evt; > - ret = extcon_register_notifier(info->cable.edev, &info->cable.nb); > + ret = extcon_register_notifier(info->cable.edev, EXTCON_NONE, > + &info->cable.nb); > if (ret) { > dev_err(&info->pdev->dev, > "failed to register extcon notifier %d\n", ret); > @@ -909,7 +910,8 @@ intr_reg_failed: > extcon_unregister_interest(&info->otg.cable); > power_supply_unregister(info->psy_usb); > psy_reg_failed: > - extcon_unregister_notifier(info->cable.edev, &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_NONE, > + &info->cable.nb); > return ret; > } > > @@ -920,7 +922,8 @@ static int axp288_charger_remove(struct platform_device *pdev) > if (info->otg.cable.edev) > extcon_unregister_interest(&info->otg.cable); > > - extcon_unregister_notifier(info->cable.edev, &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_NONE, > + &info->cable.nb); > power_supply_unregister(info->psy_usb); > > return 0; >