* Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code [not found] <558E3641.1050405@yahoo.com> @ 2015-06-29 9:15 ` Ian Abbott 2015-06-29 9:28 ` Ian Abbott 0 siblings, 1 reply; 5+ messages in thread From: Ian Abbott @ 2015-06-29 9:15 UTC (permalink / raw) To: Santhosh Pai, sudipm.mukherjee; +Cc: hsweeten, devel, gregkh, linux-kernel On 27/06/15 06:36, Santhosh Pai wrote: > > From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 > From: santhosh pai <santhosh.pai88@yahoo.com> > Date: Mon, 22 Jun 2015 23:26:33 +0530 > Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error > code > > try_module_get fails when the reference count of the module is not > allowed to be incremented ,and hence -ENXIO is returned indicating > no device or address. > > Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com> > --- > drivers/staging/comedi/comedi_fops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > index d6a37e9..1ab443c 100644 > --- a/drivers/staging/comedi/comedi_fops.c > +++ b/drivers/staging/comedi/comedi_fops.c > @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file) > } > if (dev->attached && dev->use_count == 0) { > if (!try_module_get(dev->driver->module)) { > - rc = -EPERM; > + rc = -ENXIO; > goto out; > } > if (dev->open) { > The patch itself is okay, but all the stuff around the patch is a bit weird, such as: 1. all those email headers in the commit message 2. useless indentation in the commit message 3. subject line in commit message says "PATCH 2/2", but email subject line says "PATCH 1/2" 4. stray comma in email subject line 5. spaces before colon in subject lines This is taking too long, so I'll post a cleaned-up version. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code 2015-06-29 9:15 ` Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code Ian Abbott @ 2015-06-29 9:28 ` Ian Abbott 2015-06-29 9:41 ` [PATCH] staging: Comedi: comedi_fops: Fixed the return error code Ian Abbott 2015-06-29 9:44 ` Ian Abbott 0 siblings, 2 replies; 5+ messages in thread From: Ian Abbott @ 2015-06-29 9:28 UTC (permalink / raw) To: Santhosh Pai, sudipm.mukherjee; +Cc: hsweeten, devel, gregkh, linux-kernel On 29/06/15 10:15, Ian Abbott wrote: > On 27/06/15 06:36, Santhosh Pai wrote: >> >> From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 >> From: santhosh pai <santhosh.pai88@yahoo.com> >> Date: Mon, 22 Jun 2015 23:26:33 +0530 >> Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return >> error >> code >> >> try_module_get fails when the reference count of the module is not >> allowed to be incremented ,and hence -ENXIO is returned indicating >> no device or address. >> >> Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com> >> --- >> drivers/staging/comedi/comedi_fops.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/comedi/comedi_fops.c >> b/drivers/staging/comedi/comedi_fops.c >> index d6a37e9..1ab443c 100644 >> --- a/drivers/staging/comedi/comedi_fops.c >> +++ b/drivers/staging/comedi/comedi_fops.c >> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, >> struct file *file) >> } >> if (dev->attached && dev->use_count == 0) { >> if (!try_module_get(dev->driver->module)) { >> - rc = -EPERM; >> + rc = -ENXIO; >> goto out; >> } >> if (dev->open) { >> > > The patch itself is okay, but all the stuff around the patch is a bit > weird, such as: > > 1. all those email headers in the commit message > 2. useless indentation in the commit message > 3. subject line in commit message says "PATCH 2/2", but email subject > line says "PATCH 1/2" > 4. stray comma in email subject line > 5. spaces before colon in subject lines Actually, the patch doesn't apply, because it's on top of your other patch that changed -ENOSYS to -EPERM. > > This is taking too long, so I'll post a cleaned-up version. > I'll combine your two changes to the error return value into a single patch. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: Comedi: comedi_fops: Fixed the return error code 2015-06-29 9:28 ` Ian Abbott @ 2015-06-29 9:41 ` Ian Abbott 2015-06-29 9:43 ` Ian Abbott 2015-06-29 9:44 ` Ian Abbott 1 sibling, 1 reply; 5+ messages in thread From: Ian Abbott @ 2015-06-29 9:41 UTC (permalink / raw) To: Santhosh Pai, sudipm.mukherjee Cc: hsweeten, abbotti, devel, gregkh, linux-kernel From: Santhosh Pai <santhosh.pai88@yahoo.com> From: Santhosh Pai <santhosh.pai88@yahoo.com> This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or address. [IA - combined two of santhosh's changes to the error return value!] Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 985d94b..1ab443c 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file) } if (dev->attached && dev->use_count == 0) { if (!try_module_get(dev->driver->module)) { - rc = -ENOSYS; + rc = -ENXIO; goto out; } if (dev->open) { -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: Comedi: comedi_fops: Fixed the return error code 2015-06-29 9:41 ` [PATCH] staging: Comedi: comedi_fops: Fixed the return error code Ian Abbott @ 2015-06-29 9:43 ` Ian Abbott 0 siblings, 0 replies; 5+ messages in thread From: Ian Abbott @ 2015-06-29 9:43 UTC (permalink / raw) To: Santhosh Pai, sudipm.mukherjee; +Cc: hsweeten, devel, gregkh, linux-kernel On 29/06/15 10:41, Ian Abbott wrote: > From: Santhosh Pai <santhosh.pai88@yahoo.com> > > From: Santhosh Pai <santhosh.pai88@yahoo.com> Oops. I managed to screw it up as well. I'll repost it. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: Comedi: comedi_fops: Fixed the return error code 2015-06-29 9:28 ` Ian Abbott 2015-06-29 9:41 ` [PATCH] staging: Comedi: comedi_fops: Fixed the return error code Ian Abbott @ 2015-06-29 9:44 ` Ian Abbott 1 sibling, 0 replies; 5+ messages in thread From: Ian Abbott @ 2015-06-29 9:44 UTC (permalink / raw) To: Santhosh Pai, sudipm.mukherjee Cc: hsweeten, abbotti, devel, gregkh, linux-kernel From: Santhosh Pai <santhosh.pai88@yahoo.com> This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or address. [IA - combined two of santhosh's changes to the error return value!] Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 985d94b..1ab443c 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file) } if (dev->attached && dev->use_count == 0) { if (!try_module_get(dev->driver->module)) { - rc = -ENOSYS; + rc = -ENXIO; goto out; } if (dev->open) { -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-29 9:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <558E3641.1050405@yahoo.com>
2015-06-29 9:15 ` Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code Ian Abbott
2015-06-29 9:28 ` Ian Abbott
2015-06-29 9:41 ` [PATCH] staging: Comedi: comedi_fops: Fixed the return error code Ian Abbott
2015-06-29 9:43 ` Ian Abbott
2015-06-29 9:44 ` Ian Abbott
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox