From: Arjan van de Ven <arjan@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Nicolas Boichat <drinkcat@chromium.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Antti Palosaari <crope@iki.fi>, Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Anatol Pomozov <anatol.pomozov@gmail.com>
Subject: Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep
Date: Mon, 29 Jun 2015 07:35:20 -0700 [thread overview]
Message-ID: <559157A8.2050206@linux.intel.com> (raw)
In-Reply-To: <20150629142215.GE11162@sirena.org.uk>
On 6/29/2015 7:22 AM, Mark Brown wrote:
> On Mon, Jun 29, 2015 at 10:03:09PM +0800, Nicolas Boichat wrote:
>
>> regmap instances are kalloc'ed, so they cannot contain the
>> lock_class_key, which needs to be statically allocated (in .data).
>> Another option would be to preallocate a bunch of lock_class_key in
>> regmap.c, and pick from that, but that's terribly hacky...
>
> Honestly this is all starting to sound like we're having to jump through
> too many hoops for lockep (and other APIs are too from the sounds of it)
> so we should be looking at lockdep here.
lockdep assumes that there is a known lock hierarchy, at least known
to the developer.
seems like for regmap there isn't
(I would be interested to know how you avoid ABBA deadlocks btw,
can you have 2 devices, one with a hierarchy one way, and another
with the hierarchy the other way?)
next prev parent reply other threads:[~2015-06-29 14:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 9:35 [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat
2015-06-25 9:35 ` [RFC PATCH 2/2] ASoC: rt5677: Add lockdep class to silence lockdep warnings Nicolas Boichat
2015-06-25 13:21 ` [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven
2015-06-25 14:29 ` Mark Brown
2015-06-25 15:03 ` Lars-Peter Clausen
2015-06-25 15:33 ` Mark Brown
2015-06-25 15:47 ` Lars-Peter Clausen
2015-06-25 16:08 ` Mark Brown
2015-06-26 3:16 ` Nicolas Boichat
2015-06-29 12:51 ` Nicolas Boichat
2015-06-29 12:59 ` Lars-Peter Clausen
2015-06-29 14:03 ` Nicolas Boichat
2015-06-29 14:18 ` Lars-Peter Clausen
2015-06-29 15:34 ` Mark Brown
2015-06-30 4:56 ` Nicolas Boichat
2015-06-30 11:02 ` [alsa-devel] " Lars-Peter Clausen
2015-06-29 14:22 ` Mark Brown
2015-06-29 14:35 ` Arjan van de Ven [this message]
2015-06-29 15:32 ` Mark Brown
2015-06-29 15:36 ` Arjan van de Ven
2015-06-29 16:02 ` Mark Brown
2015-06-29 14:19 ` Mark Brown
2015-06-25 14:49 ` Mark Brown
2015-06-25 15:59 ` Lars-Peter Clausen
2015-06-26 2:34 ` Nicolas Boichat
2015-06-26 8:31 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559157A8.2050206@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=crope@iki.fi \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox