From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbF3Muk (ORCPT ); Tue, 30 Jun 2015 08:50:40 -0400 Received: from mout.web.de ([212.227.17.11]:53653 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbbF3Mub (ORCPT ); Tue, 30 Jun 2015 08:50:31 -0400 Message-ID: <5592908F.6060205@users.sourceforge.net> Date: Tue, 30 Jun 2015 14:50:23 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546E69D8.4040002@users.sourceforge.net> In-Reply-To: <546E69D8.4040002@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iNX6C3MaJwAKddFSHqYxwxcTeg596DP4CPh16o/w/Rb+DZfgOy/ GFQcStvU+3E8D8qQ06CSnhTr07Nsj0REJaRde77U0sbvKhePi6axYFEEii8WA/fq/oYd/JW GrGrSAe63+9i1geY1DZJiBmfQoZ6dbYldsGBhPlRK7DpDgyvdIakCYqBjXOWHqWiUJxxp+O zUsP113jn7s+EZyVBR9pg== X-UI-Out-Filterresults: notjunk:1;V01:K0:JU4ZT7kLDbw=:GRdbcgra+zQs7/tzR61UT/ RzBhu9q/2gtgA9C73SjBPNJQwhumJn3VorvzVRt5wzOp6E7Y8FmywmgrFkzgHl7TsJD2zaLKz L5g+Il7VRqntvRxiCIQxgwGoOMpqjqvpqTRqv/+NRujleaMZJ/A4162M3coj1LG31lh//SWZB 1oIVQzlqfL4t7QDlhy83ghpsOU3cBWXjD5ZR9/f+230U+sDuy/jOUeqfm2SRNPG9kdGLTcenE GgEtT5t9Sd6VHX2NzZ9cERlmdUhlGLEls0aQQ06qR7vcmXztufJyKtEG2gXJsxfxu0XQNERt4 TlIA5kgOiUjoF1m0XFWN50r8X/z+9WTXWfCG5cZSno97+Mtaby+etatW3Alab8JbpnoMyu/n0 z//zdwxp+EV+6I+55ZYeCMFn6FGaY0Wzp4Y1OM2aEcgxH4ZAssoisyVo8SBtOM7xdyrMfsrr1 /NDLOlxoxyvu+GGCD5gOPGyNX4iprrnTvVC1pED/3FjB4NvtvQ/BTAgJPDJIHRzF3zzTBOz0L fhOT7olaTmfy6BUt1nGDFQb/qkZkZ7ir38L5zSbjOJqTHTGK40AlckbmeWh+8MR9CYQgmE8A3 oaL8PFKKVr7uqLNU38TcHsUktnDdRw31U6EJFAi0dpFD6iT20qDns5S4g2d0KZyvSyzD/Acdq ys4NlFSRk+rmEZVfCgng7UWqXee4ub/N0l91sYOamBvZeSiUDbqR0D1MUC4e2yWyqxQE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Thu, 20 Nov 2014 23:18:56 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aic94xx/aic94xx_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c > index c56741f..0bfdcba 100644 > --- a/drivers/scsi/aic94xx/aic94xx_init.c > +++ b/drivers/scsi/aic94xx/aic94xx_init.c > @@ -597,8 +597,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha) > if (asd_ha->hw_prof.scb_ext) > asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext); > > - if (asd_ha->hw_prof.ddb_bitmap) > - kfree(asd_ha->hw_prof.ddb_bitmap); > + kfree(asd_ha->hw_prof.ddb_bitmap); > asd_ha->hw_prof.ddb_bitmap = NULL; > > for (i = 0; i < ASD_MAX_PHYS; i++) { > How are the chances to integrate this update suggestion into another source code repository? Regards, Markus