From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kris Borer <kborer@gmail.com>, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz,
antoine.tenart@free-electrons.com, hdegoede@redhat.com,
rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: move assignment out of if condition
Date: Tue, 30 Jun 2015 16:35:11 +0300 [thread overview]
Message-ID: <55929B0F.6060309@cogentembedded.com> (raw)
In-Reply-To: <1435669342-8333-1-git-send-email-kborer@gmail.com>
Hello.
On 6/30/2015 4:02 PM, Kris Borer wrote:
> Fix four occurrences of the checkpatch.pl error:
> ERROR: do not use assignment in if condition
> Signed-off-by: Kris Borer <kborer@gmail.com>
> ---
> drivers/usb/core/hcd.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index be5b207..e268c45 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
[...]
> @@ -2734,7 +2735,8 @@ int usb_add_hcd(struct usb_hcd *hcd,
> /* "reset" is misnamed; its role is now one-time init. the controller
> * should already have been reset (and boot firmware kicked off etc).
> */
> - if (hcd->driver->reset && (retval = hcd->driver->reset(hcd)) < 0) {
> + retval = hcd->driver->reset(hcd);
> + if (hcd->driver->reset && retval < 0) {
If hcd->driver->reset() is NULL, this change warrants a kernel oops.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-06-30 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:02 [PATCH] usb: move assignment out of if condition Kris Borer
2015-06-30 13:35 ` Sergei Shtylyov [this message]
2015-06-30 13:35 ` Oliver Neukum
2015-06-30 15:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55929B0F.6060309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=antoine.tenart@free-electrons.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmladek@suse.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox