From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbbF3NfV (ORCPT ); Tue, 30 Jun 2015 09:35:21 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:33820 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215AbbF3NfO (ORCPT ); Tue, 30 Jun 2015 09:35:14 -0400 Subject: Re: [PATCH] usb: move assignment out of if condition To: Kris Borer , gregkh@linuxfoundation.org References: <1435669342-8333-1-git-send-email-kborer@gmail.com> Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz, antoine.tenart@free-electrons.com, hdegoede@redhat.com, rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <55929B0F.6060309@cogentembedded.com> Date: Tue, 30 Jun 2015 16:35:11 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1435669342-8333-1-git-send-email-kborer@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 6/30/2015 4:02 PM, Kris Borer wrote: > Fix four occurrences of the checkpatch.pl error: > ERROR: do not use assignment in if condition > Signed-off-by: Kris Borer > --- > drivers/usb/core/hcd.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index be5b207..e268c45 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c [...] > @@ -2734,7 +2735,8 @@ int usb_add_hcd(struct usb_hcd *hcd, > /* "reset" is misnamed; its role is now one-time init. the controller > * should already have been reset (and boot firmware kicked off etc). > */ > - if (hcd->driver->reset && (retval = hcd->driver->reset(hcd)) < 0) { > + retval = hcd->driver->reset(hcd); > + if (hcd->driver->reset && retval < 0) { If hcd->driver->reset() is NULL, this change warrants a kernel oops. [...] WBR, Sergei