From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbbF3Rpg (ORCPT ); Tue, 30 Jun 2015 13:45:36 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:50645 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbF3Rp0 (ORCPT ); Tue, 30 Jun 2015 13:45:26 -0400 Message-ID: <5592D5AB.2020802@collabora.co.uk> Date: Tue, 30 Jun 2015 19:45:15 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz , Javier Martinez Canillas CC: Krzysztof Kozlowski , Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Dan Carpenter , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Subject: Re: [PATCH] clk: samsung: fix cpu clock's flags checking References: <1435598978-21800-1-git-send-email-b.zolnierkie@samsung.com> <5591DD9B.4030507@samsung.com> <7416838.2ZUPGjSqFp@amdc1976> In-Reply-To: <7416838.2ZUPGjSqFp@amdc1976> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Bartlomiej, On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: >> On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski >> wrote: >> > On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: >> >> CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were >> >> incorrectly used as a bit numbers. Fix it. >> >> >> >> Tested on Exynos4210 based Origen board and on Exynos5250 based >> >> Arndale board. >> >> >> >> Cc: Tomasz Figa >> >> Cc: Michael Turquette >> >> Cc: Javier Martinez Canillas >> >> Cc: Thomas Abraham >> >> Reported-by: Dan Carpenter >> >> Signed-off-by: Bartlomiej Zolnierkiewicz >> >> --- >> >> drivers/clk/samsung/clk-cpu.c | 10 +++++----- >> >> 1 file changed, 5 insertions(+), 5 deletions(-) >> > >> > Reviewed-by: Krzysztof Kozlowski >> > >> >> Looks good to me as well. >> >> Reviewed-by: Javier Martinez Canillas > > Krzysztof has noted that I should use your @dowhile0.org e-mail address > instead of @collabora.co.uk one, is this right? > I don't know what is the policy for tags but Krzysztof is correct that this email address is going away this week so for future patches please use my personal @dowhile0.org address instead. Best regards, Javier