From: Sohny Thomas <sohnythomas@zoho.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date: Wed, 1 Jul 2015 14:04:48 +0530 [thread overview]
Message-ID: <5593A628.1060008@zoho.com> (raw)
In-Reply-To: <20150701080242.GD2411@sudip-PC>
On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
> <snip>
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this "else"?
>> I did this so that the code is more readable and understandable, I
>> checked and checkpatch didn't call this out , so its clean.
>>
>> Otherwise the above code looks like this
>>
>> if(i)
>> return 1;
>> return 0;
> you should update your tree. virtpci folder has been deleted from
> unisys driver.
> As you are using an old tree, maybe that explains why checkpatch is not
> giving the error.
This is from linux-stable branch and I updated it just yesterday, so looks like the folders still there
>
> regards
> sudip
>
next prev parent reply other threads:[~2015-07-01 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 21:35 [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue Sohny Thomas
2015-07-01 6:57 ` Sudip Mukherjee
2015-07-01 7:36 ` Sohny Thomas
2015-07-01 8:01 ` Julia Lawall
2015-07-01 9:20 ` Sohny Thomas
2015-07-01 9:35 ` Julia Lawall
2015-07-01 8:02 ` Sudip Mukherjee
2015-07-01 8:34 ` Sohny Thomas [this message]
2015-07-01 9:15 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593A628.1060008@zoho.com \
--to=sohnythomas@zoho.com \
--cc=benjamin.romer@unisys.com \
--cc=bryan.thompson@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=erik.arfvidson@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox