From: Clemens Ladisch <clemens@ladisch.de>
To: Joe Perches <joe@perches.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Julia Lawall <julia.lawall@lip6.fr>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: kernel coding style: prefer array to &array[0] ?
Date: Wed, 01 Jul 2015 13:54:29 +0200 [thread overview]
Message-ID: <5593D4F5.1090106@ladisch.de> (raw)
In-Reply-To: <1435685746.12101.18.camel@perches.com>
Joe Perches wrote:
> It seems most in-kernel uses are 'array' rather than '&array[0]'
>
> Most of the time, using array is simpler to read than &array[0].
>
> Exceptions exists when addresses for consecutive members are
> used like func(&array[0], &array[1]);
I use '&array[0]' when I want to get a pointer to a single object that
happens to be the first one in an array.
> Should this preference be put into checkpatch and/or CodingStyle?
How about the following low-hanging fruit?
foo(..., &array[0], ARRAY_SIZE(array), ...)
Regards,
Clemens
next prev parent reply other threads:[~2015-07-01 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 17:35 RFC: kernel coding style: prefer array to &array[0] ? Joe Perches
2015-07-01 6:10 ` Julia Lawall
2015-07-01 11:54 ` Clemens Ladisch [this message]
2015-07-01 12:15 ` Dan Carpenter
2015-07-01 12:26 ` Julia Lawall
2015-07-01 14:53 ` Joe Perches
2015-07-01 22:33 ` Dmitry Torokhov
2015-07-01 23:04 ` Joe Perches
2015-07-05 21:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593D4F5.1090106@ladisch.de \
--to=clemens@ladisch.de \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox