Re: RFC: kernel coding style: prefer array to &array[0] ?

Dan Carpenter
2015-07-01T12:15:49Z

On Wed, Jul 01, 2015 at 01:54:29PM +0200, Clemens Ladisch wrote:
> Joe Perches wrote:
> > It seems most in-kernel uses are 'array' rather than '&array[0]'
> >
> > Most of the time, using array is simpler to read than &array[0].
> >
> > Exceptions exists when addresses for consecutive members are
> > used like func(&array[0], &array[1]);
>
> I use '&array[0]' when I want to get a pointer to a single object that
> happens to be the first one in an array.

Yeah. Of course, you're right. Otherwise it ends up confusing static
checkers if you want the first element or the whole array.

>
> > Should this preference be put into checkpatch and/or CodingStyle?
>
> How about the following low-hanging fruit?
>
> foo(..., &array[0], ARRAY_SIZE(array), ...)

Yes, to this also. I doubt checkpatch.pl will find a meaningful number
of these but doing that is annoying thing.

regards,
dan carpenter