From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730AbbGANBj (ORCPT ); Wed, 1 Jul 2015 09:01:39 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:58359 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbbGANBb (ORCPT ); Wed, 1 Jul 2015 09:01:31 -0400 Message-ID: <5593E59B.9090304@ti.com> Date: Wed, 1 Jul 2015 09:05:31 -0400 From: Vitaly Andrianov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mark Rutland CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux@arm.linux.org.uk" , "ssantosh@kernel.org" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH] keystone: dts: add psci command definition References: <1435752784-30639-1-git-send-email-vitalya@ti.com> <1435752784-30639-2-git-send-email-vitalya@ti.com> <20150701124101.GB2310@leverpostej> In-Reply-To: <20150701124101.GB2310@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2015 08:41 AM, Mark Rutland wrote: > On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote: >> This commit adds definition for cpu_on, cpu_off and cpu_suspend commands. >> These definitions must match the corresponding PSCI definitions in >> boot monitor. >> >> Signed-off-by: Vitaly Andrianov >> --- >> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi >> index c06542b..ab60fca 100644 >> --- a/arch/arm/boot/dts/keystone.dtsi >> +++ b/arch/arm/boot/dts/keystone.dtsi >> @@ -58,6 +58,14 @@ >> ; >> }; >> >> + psci { >> + compatible = "arm,psci"; >> + method = "smc"; >> + cpu_suspend = <0x84000001>; >> + cpu_off = <0x84000002>; >> + cpu_on = <0x84000003>; >> + }; > > It would be nice to have this injected automatically by the bootlaoder > when PSCI is present, as that way users of existing systems can upgrade > their DTB and still have things boot. > > Thanks, > Mark. > So, KS2 kernel doesn't need that commit and has to wait this from u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is just responsible to load and start it, but doesn't know whether PSCI is supported. In any case you are right. The DTS also doesn't know whether boot- monitor supports PSCI. It is better to make u-boot to fix up the dts. Let's forget about this patch. I'll work on dts fix-up in u-boot. Thanks, Vitaly >> + >> soc { >> #address-cells = <1>; >> #size-cells = <1>; >> -- >> 1.9.1 >>