From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2960DC6FA82 for ; Fri, 23 Sep 2022 11:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231600AbiIWLAt (ORCPT ); Fri, 23 Sep 2022 07:00:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbiIWLAq (ORCPT ); Fri, 23 Sep 2022 07:00:46 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEEA1AF0E9; Fri, 23 Sep 2022 04:00:43 -0700 (PDT) Received: from p508fdb48.dip0.t-ipconnect.de ([80.143.219.72] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1obgQ5-00067T-Qn; Fri, 23 Sep 2022 13:00:33 +0200 From: Heiko Stuebner To: xianting.tian@linux.alibaba.com, palmer@dabbelt.com, palmer@rivosinc.com, liaochang1@huawei.com, jszhang@kernel.org, arnd@arndb.de, guoren@kernel.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, Guo Ren , Guo Ren , Catalin Marinas , Thomas Gleixner Subject: Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h Date: Fri, 23 Sep 2022 13:00:32 +0200 Message-ID: <5594014.Sb9uPGUboI@phil> In-Reply-To: <20220921033134.3133319-4-guoren@kernel.org> References: <20220921033134.3133319-1-guoren@kernel.org> <20220921033134.3133319-4-guoren@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@kernel.org: > From: Guo Ren > > Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which > has been done in include/linux/smp.h. nit: the commit message could reference the commit that brought in the generic declarations, which was 6f1f942cd5fb ("smp: kernel/panic.c - silence warnings") other than that Reviewed-by: Heiko Stuebner > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > Acked-by: Catalin Marinas > Cc: Arnd Bergmann > Cc: Thomas Gleixner > --- > arch/arm64/include/asm/smp.h | 1 - > arch/x86/include/asm/crash.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h > index fc55f5a57a06..a108ac93fd8f 100644 > --- a/arch/arm64/include/asm/smp.h > +++ b/arch/arm64/include/asm/smp.h > @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void) > */ > bool cpus_are_stuck_in_kernel(void); > > -extern void crash_smp_send_stop(void); > extern bool smp_crash_stop_failed(void); > extern void panic_smp_self_stop(void); > > diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h > index 8b6bd63530dc..6a9be4907c82 100644 > --- a/arch/x86/include/asm/crash.h > +++ b/arch/x86/include/asm/crash.h > @@ -7,6 +7,5 @@ struct kimage; > int crash_load_segments(struct kimage *image); > int crash_setup_memmap_entries(struct kimage *image, > struct boot_params *params); > -void crash_smp_send_stop(void); > > #endif /* _ASM_X86_CRASH_H */ >