* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file
2015-07-01 13:44 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas
@ 2015-07-01 14:13 ` Frans Klaver
2015-07-01 15:46 ` Sohny Thomas
2015-07-01 14:27 ` Dan Carpenter
2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas
2 siblings, 1 reply; 7+ messages in thread
From: Frans Klaver @ 2015-07-01 14:13 UTC (permalink / raw)
To: Sohny Thomas
Cc: Greg KH, arve, riandrews, Sumit Semwal, carlos,
linux-kernel@vger.kernel.org, kernel-janitors
On Wed, Jul 1, 2015 at 3:44 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
>
> - removed non-existent issue from TODO file
> kuid_t or uid_t not present in staging/android
>
> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
s,-of-,-off-,
You can remove the leading dash (-). Could you elaborate on why this
issue is non existent?
Thanks,
Frans
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file
2015-07-01 14:13 ` Frans Klaver
@ 2015-07-01 15:46 ` Sohny Thomas
0 siblings, 0 replies; 7+ messages in thread
From: Sohny Thomas @ 2015-07-01 15:46 UTC (permalink / raw)
To: Frans Klaver
Cc: Greg KH, arve, riandrews, Sumit Semwal, carlos,
linux-kernel@vger.kernel.org, kernel-janitors
On Wednesday 01 July 2015 07:43 PM, Frans Klaver wrote:
> On Wed, Jul 1, 2015 at 3:44 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
>>
>> - removed non-existent issue from TODO file
>> kuid_t or uid_t not present in staging/android
>>
>> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
>
> s,-of-,-off-,
>
> You can remove the leading dash (-). Could you elaborate on why this
> issue is non existent?
Thanks for catching the off. According to the TODO the kuid_t is not present in any files under staging/android
So I said its non-existent
>
> Thanks,
> Frans
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file
2015-07-01 13:44 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas
2015-07-01 14:13 ` Frans Klaver
@ 2015-07-01 14:27 ` Dan Carpenter
2015-07-01 15:50 ` Sohny Thomas
2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas
2 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2015-07-01 14:27 UTC (permalink / raw)
To: Sohny Thomas
Cc: gregkh, arve, riandrews, sumit.semwal, carlos,
linux-kernel@vger.kernel.org, kernel-janitors
On Wed, Jul 01, 2015 at 07:14:38PM +0530, Sohny Thomas wrote:
>
> - removed non-existent issue from TODO file
> kuid_t or uid_t not present in staging/android
>
> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
The patch is all mangled. It barely seems to match the description but
I can't tell for sure because of the mangling.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file
2015-07-01 14:27 ` Dan Carpenter
@ 2015-07-01 15:50 ` Sohny Thomas
0 siblings, 0 replies; 7+ messages in thread
From: Sohny Thomas @ 2015-07-01 15:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, arve, riandrews, sumit.semwal, carlos,
linux-kernel@vger.kernel.org, kernel-janitors
On Wednesday 01 July 2015 07:57 PM, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 07:14:38PM +0530, Sohny Thomas wrote:
>>
>> - removed non-existent issue from TODO file
>> kuid_t or uid_t not present in staging/android
>>
>> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
>
>
> The patch is all mangled. It barely seems to match the description but
> I can't tell for sure because of the mangling.
I sent an another version, Hope its not mangled now
Thanks for your time.
-Sohny
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 ] Staging: Android: Fixes for TODO file
2015-07-01 13:44 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas
2015-07-01 14:13 ` Frans Klaver
2015-07-01 14:27 ` Dan Carpenter
@ 2015-07-01 15:49 ` Sohny Thomas
2015-07-14 22:50 ` Greg KH
2 siblings, 1 reply; 7+ messages in thread
From: Sohny Thomas @ 2015-07-01 15:49 UTC (permalink / raw)
To: gregkh, arve, riandrews, sumit.semwal, carlos
Cc: linux-kernel@vger.kernel.org, kernel-janitors
Removed non-existent issue from TODO file
No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory
Signed-off-by: Sohny Thomas <sohnythomas@zoho.com>
---
drivers/staging/android/TODO | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index 06954cd..b15fb0d 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -5,13 +5,6 @@ TODO:
- make sure things build as modules properly
- add proper arch dependencies as needed
- audit userspace interfaces to make sure they are sane
- - kuid_t should never be exposed to user space as it is
- kernel internal type. Data structure for this kuid_t is:
- typedef struct {
- uid_t val;
- } kuid_t;
- - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
- - ("staging: android: logger: use kuid_t instead of uid_t")
Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc:
Brian Swetland <swetland@google.com>
--
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3 ] Staging: Android: Fixes for TODO file
2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas
@ 2015-07-14 22:50 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-07-14 22:50 UTC (permalink / raw)
To: Sohny Thomas
Cc: arve, riandrews, sumit.semwal, carlos,
linux-kernel@vger.kernel.org, kernel-janitors
On Wed, Jul 01, 2015 at 09:19:11PM +0530, Sohny Thomas wrote:
> Removed non-existent issue from TODO file
> No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory
>
> Signed-off-by: Sohny Thomas <sohnythomas@zoho.com>
> ---
> drivers/staging/android/TODO | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> index 06954cd..b15fb0d 100644
> --- a/drivers/staging/android/TODO
> +++ b/drivers/staging/android/TODO
> @@ -5,13 +5,6 @@ TODO:
> - make sure things build as modules properly
> - add proper arch dependencies as needed
> - audit userspace interfaces to make sure they are sane
> - - kuid_t should never be exposed to user space as it is
> - kernel internal type. Data structure for this kuid_t is:
> - typedef struct {
> - uid_t val;
> - } kuid_t;
> - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
> - - ("staging: android: logger: use kuid_t instead of uid_t")
>
> Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc:
> Brian Swetland <swetland@google.com>
Doesn't apply to the tree :(
^ permalink raw reply [flat|nested] 7+ messages in thread