From: Randy Dunlap <rdunlap@infradead.org>
To: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: Fix out-of-tree build
Date: Wed, 01 Jul 2015 10:35:10 -0700 [thread overview]
Message-ID: <559424CE.9070500@infradead.org> (raw)
In-Reply-To: <1435525233-14656-1-git-send-email-richard@nod.at>
On 06/28/15 14:00, Richard Weinberger wrote:
> Commit 30b11ee9a (um: Remove copy&paste code from init.h)
> uncovered an issue wrt. out-of-tree builds.
> For out-of-tree builds, we must not rely on relative paths.
> Before 30b11ee9a it worked by chance as no host code included
> generated header files.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Works for me. Please merge so that linux-next builds stop failing.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/um/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/Makefile b/arch/um/Makefile
> index 098ab33..e3abe6f 100644
> --- a/arch/um/Makefile
> +++ b/arch/um/Makefile
> @@ -70,8 +70,8 @@ KBUILD_AFLAGS += $(ARCH_INCLUDE)
>
> USER_CFLAGS = $(patsubst $(KERNEL_DEFINES),,$(patsubst -I%,,$(KBUILD_CFLAGS))) \
> $(ARCH_INCLUDE) $(MODE_INCLUDE) $(filter -I%,$(CFLAGS)) \
> - -D_FILE_OFFSET_BITS=64 -idirafter include \
> - -D__KERNEL__ -D__UM_HOST__
> + -D_FILE_OFFSET_BITS=64 -idirafter $(srctree)/include \
> + -idirafter $(obj)/include -D__KERNEL__ -D__UM_HOST__
>
> #This will adjust *FLAGS accordingly to the platform.
> include $(ARCH_DIR)/Makefile-os-$(OS)
>
--
~Randy
prev parent reply other threads:[~2015-07-01 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 21:00 [PATCH] um: Fix out-of-tree build Richard Weinberger
2015-07-01 17:35 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559424CE.9070500@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox