From: Peter Hung <hpeter@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting
Date: Thu, 2 Jul 2015 11:08:43 +0800 [thread overview]
Message-ID: <5594AB3B.90301@gmail.com> (raw)
In-Reply-To: <559455C7.3030002@roeck-us.net>
Hi Guenter,
Guenter Roeck 於 2015/7/2 上午 05:04 寫道:
> Hi Peter,
>> + } else {
>> + size = ARRAY_SIZE(fxxxx_temp_beep_attr[0];
>
> TskTsk ... turns out you didn't even compile test this code.
> How am I supposed to know that it is working ?
Sorry, It's my fault.
I should re-testing patch after fix checkpatch.sh warnings.
I'll re-confirm all patches again before send it to maintainer.
--
With Best Regards,
Peter Hung
next prev parent reply other threads:[~2015-07-02 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 1:31 [PATCH V2 0/3] hwmon:f71882fg add new Fintek SuperIO support Peter Hung
2015-06-30 1:31 ` [PATCH V2 1/3] hwmon:f71882fg add f81866/f71868 " Peter Hung
2015-06-30 1:31 ` [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting Peter Hung
2015-07-01 21:04 ` Guenter Roeck
2015-07-02 3:08 ` Peter Hung [this message]
2015-06-30 1:31 ` [PATCH V2 3/3] hwmon:f71882fg fix f81866a voltage protection Peter Hung
2015-07-01 17:53 ` [PATCH V2 0/3] hwmon:f71882fg add new Fintek SuperIO support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5594AB3B.90301@gmail.com \
--to=hpeter@gmail.com \
--cc=hpeter+linux_kernel@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).