[PATCH 0/2] thermal: exynos: Fix minor issue

[PATCH 0/2] thermal: exynos: Fix minor issue

[Chanwoo Choi]

This patch fixes the two minor issue. The first patch add the CONFIG_THERMAL_OF
dependency and second patch removes the unused code.

Chanwoo Choi (2):
  thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF
  thermal: exynos: Remove unused code related to platform_data on probe()

 drivers/thermal/samsung/Kconfig      | 2 +-
 drivers/thermal/samsung/exynos_tmu.c | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
1.8.5.5

[PATCH 1/2] thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF

[Chanwoo Choi]

The exynos thermal driver use the of_thermal_*() API to parse the basic data
for thermal management from devicetree file. So, if CONFIG_EXYNOS_THERMAL is
selected without CONFIG_THERMAL_OF, kernel can build it without any problem.
But, exynos thermal driver is not working with following error log. This patch
add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF.

[    1.458644] get_th_reg: Cannot get trip points from of-thermal.c!
[    1.459096] get_th_reg: Cannot get trip points from of-thermal.c!
[    1.465211] exynos4412_tmu_initialize: No CRITICAL trip point defined at of-thermal.c!

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/thermal/samsung/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index c8e35c1a43dc..e0da3865e060 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
 	tristate "Exynos thermal management unit driver"
-	depends on OF
+	depends on THERMAL_OF
 	help
 	  If you say yes here you get support for the TMU (Thermal Management
 	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
-- 
1.8.5.5

[PATCH 2/2] thermal: exynos: Remove unused code related to platform_data on probe()

[Chanwoo Choi]

This patch removes the unused code related to struct exynos_tmu_platform_data
because exynos_tmu_probe() don't handle the struct exynos_tmu_platform_data *pdata.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 531f4b179871..10e46a1a4bb3 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1296,7 +1296,6 @@ static struct thermal_zone_of_device_ops exynos_sensor_ops = {
 
 static int exynos_tmu_probe(struct platform_device *pdev)
 {
-	struct exynos_tmu_platform_data *pdata;
 	struct exynos_tmu_data *data;
 	int ret;
 
@@ -1318,8 +1317,6 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_sensor;
 
-	pdata = data->pdata;
-
 	INIT_WORK(&data->irq_work, exynos_tmu_work);
 
 	data->clk = devm_clk_get(&pdev->dev, "tmu_apbif");
-- 
1.8.5.5

Re: [PATCH 2/2] thermal: exynos: Remove unused code related to platform_data on probe()

[Krzysztof Kozlowski]

On 02.07.2015 15:40, Chanwoo Choi wrote:
> This patch removes the unused code related to struct exynos_tmu_platform_data
> because exynos_tmu_probe() don't handle the struct exynos_tmu_platform_data *pdata.
> 
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH 0/2] thermal: exynos: Fix minor issue

[Lukasz Majewski]

Hi Chanwoo,

> This patch fixes the two minor issue. The first patch add the
> CONFIG_THERMAL_OF dependency and second patch removes the unused code.
> 
> Chanwoo Choi (2):
>   thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of
> CONFIG_OF thermal: exynos: Remove unused code related to
> platform_data on probe()
> 
>  drivers/thermal/samsung/Kconfig      | 2 +-
>  drivers/thermal/samsung/exynos_tmu.c | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 

Thanks for your work.

Applied to my tree: linux-samusng-thermal/fixes


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group