public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: "Xiao, Jin" <jin.xiao@intel.com>, Joerg Roedel <jroedel@suse.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, bp@suse.de, boris.ostrovsky@oracle.com,
	dave.hansen@linux.intel.com, rientjes@google.com,
	imammedo@redhat.com, paulmck@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@kernel.org, xinhuix.pan@intel.com
Subject: Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online
Date: Thu, 02 Jul 2015 17:20:28 +0800	[thread overview]
Message-ID: <5595025C.5050306@linux.intel.com> (raw)
In-Reply-To: <5594E1F2.5060602@intel.com>

On 2015/7/2 15:02, Xiao, Jin wrote:
> Hi Joerg,
>
> On 7/2/2015 2:52 PM, Joerg Roedel wrote:
>> Hi Jin,
>>
>> On Thu, Jul 02, 2015 at 12:24:34PM +0800, xiao jin wrote:
>>> [  106.107851] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040
>>> [  106.116702] IP:
>>> [  106.118490]  [<ffffffff810044f6>] check_irq_vectors_for_cpu_disable+0x76/0x180
>> This might be the same issue I fixed with:
>>
>>     d97eb8966c91 x86/irq: Check for valid irq descriptor in check_irq_vectors_for_cpu_disable()
>>
>> Can you try whether applying this patch on your kernel fixes your
>> issue?
>>
> Yes, I agree d97eb8966c91 fix the IPANIC. I just notice a description from http://lkml.kernel.org/r/20150204132754.GA10078@suse.de.
>
> I wish to share the debug result and root cause from my side.

commit d97eb8966c91f2c9d05f0a22eb89ed5b76d966d1 looks like a workaround.

Could Jin's patch be merged also?
free_msi_irqs does have a race with smp_callin=>..=>__setup_vector_irq.


  reply	other threads:[~2015-07-02  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  4:24 [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online xiao jin
2015-07-02  6:52 ` Joerg Roedel
2015-07-02  7:02   ` Xiao, Jin
2015-07-02  9:20     ` Zhang, Yanmin [this message]
2015-07-02 12:50       ` Thomas Gleixner
2015-07-03  2:02         ` Xiao, Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5595025C.5050306@linux.intel.com \
    --to=yanmin_zhang@linux.intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@suse.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=imammedo@redhat.com \
    --cc=jin.xiao@intel.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xinhuix.pan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox