From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching
Date: Thu, 2 Jul 2015 14:32:11 +0300 [thread overview]
Message-ID: <5595213B.7080809@cogentembedded.com> (raw)
In-Reply-To: <1435824869-22784-1-git-send-email-phil.edworthy@renesas.com>
Hello.
On 7/2/2015 11:14 AM, Phil Edworthy wrote:
> Both USB Host (pci0) and Function (USBHS) drivers are enabled.
> The USB PHY driver determines which IP block should be connected
> based on vbus and id signals read via gpios.
> Note that switch SW5 and SW6 on Koelsch board needs to be set to
> position 3 for this to work.
[...]
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index cffe33f..1bb34d0 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -615,7 +615,6 @@
>
> &pci0 {
> status = "okay";
> - pinctrl-0 = <&usb0_pins>;
> pinctrl-names = "default";
As you're removing "pinctrl-0" prop, you also should remove "pinctrl-names".
> };
>
> @@ -627,13 +626,15 @@
>
> &hsusb {
> status = "okay";
> - pinctrl-0 = <&usb0_pins>;
Likewise.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-07-02 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 8:14 [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching Phil Edworthy
2015-07-02 11:32 ` Sergei Shtylyov [this message]
2015-07-02 12:11 ` Phil Edworthy
2015-07-03 0:14 ` Simon Horman
2015-07-07 12:16 ` [PATCH v4] ARM: shmobile: " Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5595213B.7080809@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox