Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style

Alexandre Belloni
2015-06-30T21:53:29Z

On 30/06/2015 at 22:28:42 +0200, Arnd Bergmann wrote :
> On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
> > +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR)
> > +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR)
> > +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)
> >
>
> How about removing these macros entirely? I'm not aware of other drivers
> doing it like this, and it does not seem to add any value?
>
> At the same time, you could use readl_relaxed() to make the driver
> endian-safe.
>

I think using readl_relaxed() would break avr32.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering