Re: [PATCH] firmware: qcom: scm: Peripheral Authentication Service

[Stephen Boyd <sboyd@codeaurora.org>]

On 06/30/2015 12:46 PM, Bjorn Andersson wrote:
> +
> +int __qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size)
> +{
> +	dma_addr_t mdata_phys;
> +	void *mdata_buf;
> +	u32 scm_ret;
> +	int ret;
> +	struct pas_init_image_req {
> +		u32 proc;
> +		u32 image_addr;

Please mark these as __le32 and do the appropriate conversions to little
endian. Also consider removing the struct name and just make it
anonymous, i.e.

    struct {
        __le32 proc;
        __le32 image_addr;
    } cmd;

> +	} request;
> +
> +	/*
> +	 * During the scm call memory protection will be enabled for the meta
> +	 * data blob, so make sure it's physically contiguous, 4K aligned and
> +	 * non-cachable to avoid XPU violations.
> +	 */
> +	mdata_buf = dma_alloc_coherent(NULL, size, &mdata_phys, GFP_KERNEL);
> +	if (!mdata_buf) {
> +		pr_err("Allocation of metadata buffer failed.\n");
> +		return -ENOMEM;
> +	}
> +	memcpy(mdata_buf, metadata, size);
> +
> +	request.proc = peripheral;
> +	request.image_addr = mdata_phys;
> +
> +	ret = qcom_scm_call(QCOM_SCM_SVC_PIL, QCOM_SCM_PAS_INIT_IMAGE_CMD,
> +			    &request, sizeof(request),
> +			    &scm_ret, sizeof(scm_ret));
> +
> +	dma_free_coherent(NULL, size, mdata_buf, mdata_phys);
> +
> +	return ret ? : scm_ret;
> +}
> +
> +int __qcom_scm_pas_mem_setup(u32 peripheral, phys_addr_t addr, phys_addr_t size)
> +{
> +	u32 scm_ret;
> +	int ret;
> +	struct pas_init_image_req {
> +		u32 proc;
> +		u32 addr;
> +		u32 len;
> +	} request;

Same comment here.

> +
> +	request.proc = peripheral;
> +	request.addr = addr;
> +	request.len = size;
> +
> +	ret = qcom_scm_call(QCOM_SCM_SVC_PIL, QCOM_SCM_PAS_MEM_SETUP_CMD,
> +			    &request, sizeof(request),
> +			    &scm_ret, sizeof(scm_ret));
> +
> +	return ret ? : scm_ret;
> +}
> +
>
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project