From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbbGBQqK (ORCPT ); Thu, 2 Jul 2015 12:46:10 -0400 Received: from mout.web.de ([212.227.15.14]:55815 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753721AbbGBQp6 (ORCPT ); Thu, 2 Jul 2015 12:45:58 -0400 Message-ID: <55956AC1.9000902@users.sourceforge.net> Date: Thu, 02 Jul 2015 18:45:53 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "David S. Miller" , netdev@vger.kernel.org CC: Linux Kernel Mailing List , kernel-janitors , Julia Lawall Subject: [PATCH] netlink: Delete an unnecessary check before the function call "module_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:v4Jo0hL30uIMsh4gD7W6YH7HDjUKdDuq70M/hbooqZZyoj+8pkH DwBx7fQ2d052bTNfoP8Z0c6f11/UNA5gAMGM2obYXzhtM6z83A7aSyE879SO7xrlrkfJplM TVmSkP1taxeJynvn7DzLqyHrf9iym859rg5bLrkVsbhub7GA36eE3sPfx2mF/zl0lqZx0m4 O/6g5KomIOmTeYhIzp0aQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mtKv8R1W4sM=:wANqCaSbwsO+1nQ+8x2aMJ FoZhgGnWYmmzVlzZzGHsw8TjzuPKNzrt7tke4YJ5YPFul7tZtjn9C66uXOy589OPsweECQ7zG 5fTIMHL2aXjfMdM8iDyHqw0oliRX9WmBJNgsV2V555n266vjfAttwoxvhnvk1bYQvhduLuYeY 47X/AdD2kfZARZvKGmiGGWHOmWsdLZKJ7LVpcBYa50WrfpovbXiHW1WoFCMzb9t3WbPQtaeG5 679pA2mYGHWK04D7f9L/KJfgRrfXyUXJCbXjKmmKekhNsv3/XV52f5M5mx74difSozCKodubp q4GRugQCyt5YnByVySeT7rclHytU7GLuLBH5/KHCTK47CNNo7RgNikYA8zZfAb2krXlXGNaF6 YYPhQofp4AqhmkmY374DdnAnxi3Fm7dnGX95gd5aZPydlI/+uVTI2Nv/trsxqCyVbF4pikTzG E8QX430qaq7htOEgQHHhVFaPBiGZuvw+0/N8adyyOqgtOjh5TRYfwvuCXt8LgUICNLd0xZxMK wVwaAXTwBZh8Slo2paai2+ZMGZyRbX92vlX0JjJB+FbCWsliPULWZUXcyNOSjupabXeH3haFm vvHAHOVNxl8YqF1PpveE+o1zVS/NP3vJp0ELpV2OJUUkliWJm7fnWJKkUF1GCsYDJhGPMVjCl UUHO/8vreu8WSFbY4vLdMlD5tW9XvN3teEIrdjLMnL6CjLsWmKH7WXtspMYBpN/J0dvE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 2 Jul 2015 18:38:12 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index dea9253..9a0ae71 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt) out: spin_unlock(&netlink_tap_lock); - if (found && nt->module) + if (found) module_put(nt->module); return found ? 0 : -ENODEV; -- 2.4.5