From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbbGBUVj (ORCPT ); Thu, 2 Jul 2015 16:21:39 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49351 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751615AbbGBUVb (ORCPT ); Thu, 2 Jul 2015 16:21:31 -0400 Message-ID: <55959D48.7090505@free-electrons.com> Date: Thu, 02 Jul 2015 22:21:28 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andrew Lunn CC: Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Sebastian Hesselbarth , Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Maxime Ripard , Boris BREZILLON , Lior Amsalem , Tawfik Bayouk , Nadav Haklai Subject: Re: [PATCH] clk: mvebu: update cpu clock frequency References: <1435866158-910-1-git-send-email-gregory.clement@free-electrons.com> <20150702200459.GF13481@lunn.ch> In-Reply-To: <20150702200459.GF13481@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, thanks for your prompt review On 02/07/2015 22:04, Andrew Lunn wrote: > On Thu, Jul 02, 2015 at 09:42:38PM +0200, Gregory CLEMENT wrote: >> Since u-boot 2015_T1.0p6 there are new requency settings available. > > Hi Gregory > > Missing f in f_requency. it must have been lost in the copy and paste I will fix it. > > Also, what has u-boot got to do with this? I would expect this is a > property of the hardware. What happens is an older u-boot is used? As you probably know, a lot of "magical" initialization is done in the U-boot from Marvell. So maybe is it the reason why u-boot was mentioned. However you're right I will ask more information about especially if it is safe to have this value with an older u-boot. Thanks, Gregory > > Thanks > Andrew > >> >> Based on a patch from Nadav Haklai >> >> Signed-off-by: Gregory CLEMENT >> --- >> drivers/clk/mvebu/armada-38x.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c >> index 8bccf4ecdab6..c64037e2e89f 100644 >> --- a/drivers/clk/mvebu/armada-38x.c >> +++ b/drivers/clk/mvebu/armada-38x.c >> @@ -46,10 +46,11 @@ static u32 __init armada_38x_get_tclk_freq(void __iomem *sar) >> } >> >> static const u32 armada_38x_cpu_frequencies[] __initconst = { >> - 0, 0, 0, 0, >> - 1066 * 1000 * 1000, 0, 0, 0, >> + 666 * 1000 * 1000, 0, 800 * 1000 * 1000, 0, >> + 1066 * 1000 * 1000, 0, 1200 * 1000 * 1000, 0, >> 1332 * 1000 * 1000, 0, 0, 0, >> - 1600 * 1000 * 1000, >> + 1600 * 1000 * 1000, 0, 0, 0, >> + 1866 * 1000 * 1000, 0, 0, 2000 * 1000 * 1000, >> }; >> >> static u32 __init armada_38x_get_cpu_freq(void __iomem *sar) >> -- >> 2.1.0 >> -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com