From: "Xiao, Jin" <jin.xiao@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Joerg Roedel <jroedel@suse.de>,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
boris.ostrovsky@oracle.com, dave.hansen@linux.intel.com,
rientjes@google.com, imammedo@redhat.com,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@kernel.org, xinhuix.pan@intel.com
Subject: Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online
Date: Fri, 3 Jul 2015 10:02:35 +0800 [thread overview]
Message-ID: <5595ED3B.3000708@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1507021427530.3916@nanos>
Hi tglx,
On 7/2/2015 8:50 PM, Thomas Gleixner wrote:
>
> The whole vector stuff is racy versus cpu hotplug and Jins patch
> merily addresses a small part of it and by doing that it breaks stuff
> as well.
>
> With that patch we move the vector setup after marking the cpu online,
> which is wrong because the vector array on that cpu is not up to date
> until we call __setup_vector_irq(). Proper patch below.
>
> We still have an issue in the cpu_disable() patch, but I haven't yet
> wrapped my head around it completely.
>
> Thanks,
>
> tglx
>
Your patch is better. Thanks.
Jin
prev parent reply other threads:[~2015-07-03 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 4:24 [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online xiao jin
2015-07-02 6:52 ` Joerg Roedel
2015-07-02 7:02 ` Xiao, Jin
2015-07-02 9:20 ` Zhang, Yanmin
2015-07-02 12:50 ` Thomas Gleixner
2015-07-03 2:02 ` Xiao, Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5595ED3B.3000708@intel.com \
--to=jin.xiao@intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox