public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Iago López Galeiras" <iago@endocode.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Djalal Harouni <djalal@endocode.com>,
	Alban Crequy <alban@endocode.com>
Subject: Re: config PROC_CHILDREN
Date: Fri, 3 Jul 2015 11:10:45 +0200	[thread overview]
Message-ID: <55965195.6010602@endocode.com> (raw)
In-Reply-To: <20150703093918.75b98eb7@endymion.delvare>

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps
that's not clear for the user because as you say the Kconfig help text is missing.

I suggest adding something like:

    Provides a fast way to retrieve first level children pids of a task. See
    <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Thanks.

[1]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt

On 07/03/2015 09:39 AM, Jean Delvare wrote:
> Hi Iago,
> 
> You just introduced a Linux kernel configuration option named
> PROC_CHILDREN. It is user-visible but has no help. This is bad.
> 
> As this option appears to be selected automatically as needed, I'm not
> sure why you made it visible?
> 
> Please either hide the option, or add a help text to let the user make
> a sane decision.
> 
> Thanks,
> 

-- 

Iago López Galeiras
Software developer @ Endocode AG
iago@endocode.com

  reply	other threads:[~2015-07-03  9:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03  7:39 config PROC_CHILDREN Jean Delvare
2015-07-03  9:10 ` Iago López Galeiras [this message]
2015-07-04 17:07   ` Jean Delvare
2015-07-08 14:18     ` Iago López Galeiras
2015-07-08 14:46       ` Cyrill Gorcunov
2015-07-08 14:50       ` Djalal Harouni
2015-07-08 16:33         ` Jean Delvare
2015-07-08 16:34       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55965195.6010602@endocode.com \
    --to=iago@endocode.com \
    --cc=alban@endocode.com \
    --cc=djalal@endocode.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox