Re: Kconfig: '+config' valid syntax?

Paul Bolle
2015-07-03T09:00:38Z

On vr, 2015-07-03 at 09:33 +0200, Andreas Ruprecht wrote:
> I tested the behaviour on yesterday's linux-next, but the commit
> mentioned above will only complain for invalid characters inside the
> PARAM case and not for COMMANDs. So, as an example, if you write
> something like
>
> config ACPI_REV_OVERRIDE_POSSIBLE
> depends on X86 +
> [...]
>
> Kconfig will complain about the '+'. This, however, does not apply for
> top-level statements like 'config', 'menuconfig', and so on.

Which might explain why this silly mistake went unnoticed. (And, as I
think you implied, it doesn't help that the empty rule we're hitting
here is not commented.)

So the naive solution seems to be to also add the warning to COMMAND's
rule for '.'. A quick test suggest that would work. Am I missing some
obvious downside with that solution?

Thanks,

Paul Bolle