Re: Kconfig: '+config' valid syntax?

Andreas Ruprecht
2015-07-02T11:57:35Z

Hi,

On 07/02/2015 11:01, Paul Bolle wrote:
> [Dropped Yann. You already know Yann disappeared.]
>
> On Thu, 2015-07-02 at 10:08 +0200, Valentin Rothberg wrote:
>> commit ed013214afa7 ("ACPI / init: Make it possible to override _REV")
>> is in today's linux-next tree (i.e., next-20150702) adding the
>> following hunk to drivers/acpi/Kconfig:
>>
>> --- a/drivers/acpi/Kconfig
>> +++ b/drivers/acpi/Kconfig
>> @@ -428,6 +428,26 @@ config XPOWER_PMIC_OPREGION
>> help
>> This config adds ACPI operation region support for XPower
>> AXP288 PMIC.
>>
>> ++config ACPI_REV_OVERRIDE_POSSIBLE
>
> (Odd. Botched conflict resolution?)
>
>> + bool "Allow supported ACPI revision to be overriden"
>> + depends on X86
>> + default y
>> [...]
>>
>> By having a close look at the first added line, we can see that
>> '+config ACPI_...' is added. To my great surprise, it's valid Kconfig
>> syntax.
>
> I played a bit with this. It seems you can basically add a '+' anywhere
> you like and kconfig will just ignore it.
>
>> How is that possible? IMHO it's an invalid token, such that
>> Kconfig should complain about it. Or do I miss something?
>
> Welcome to the wonders of lex and yacc!
>
> I try to spend as little time as possible looking at the lex rules, so
> I'm just guessing here. Anyhow, you might start by looking at this
> snippet in zconf.l:
> . {
> unput(yytext[0]);
> BEGIN(COMMAND);
> }
>
>
> <COMMAND>{
> {n}+ {
> [...]
> }
> .
> \n {
> BEGIN(INITIAL);
> current_file->lineno++;
> return T_EOL;
> }
> }
>
> Which perhaps translates to:
> - ignore unknown stuff for now and go in COMMAND state;
> - do something if we encounter some text ({n} = [A-Za-z0-9_]);
> - go in INITIAL state if we encounter newlines or unknown stuff.

This is _almost_ true (which I think is the problem). The rule for "."
is empty, and not the same rule as for \n. So what happens here, is that
any unknown characters are simply ignored until something in {n}+ shows up.

If I add something like the following instead:
+ . {
+ fprintf(stderr, "something else: %s\n", yytext);
+ BEGIN(INITIAL);
+ }

then Kconfig prints the message for the "+", but unfortunately also lots
of "-" (which come from the occasional "---help---" instead of "help".
As it looks to me, they are only ignored one step later inside the
<PARAM> case.

So changing it like the above is not the solution, but at least we know
where the silent ignore is coming from...

Any idea how to properly fix this?

Regards,

Andreas